Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754660AbcC0HwB (ORCPT ); Sun, 27 Mar 2016 03:52:01 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:34920 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845AbcC0Hvx (ORCPT ); Sun, 27 Mar 2016 03:51:53 -0400 Subject: Re: [PATCH 01/31] bitops: add parity functions To: Martin Kepplinger , Andrew Morton , Denys Vlasenko References: <1458788612-4367-1-git-send-email-zhaoxiu.zeng@gmail.com> <56F3A77D.6060802@redhat.com> <20160324152815.3489c6d54270f278e5dc7db4@linux-foundation.org> <5C852AF0-E161-4219-B8C8-7CE3140B73C3@posteo.de> Cc: Arnd Bergmann , Sasha Levin , Ingo Molnar , Yury Norov , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org From: "zhaoxiu.zeng" Message-ID: <56F790F3.1080801@gmail.com> Date: Sun, 27 Mar 2016 15:51:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <5C852AF0-E161-4219-B8C8-7CE3140B73C3@posteo.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 602 Lines: 20 On 2016/3/27 6:08, Martin Kepplinger wrote: > We do. > > Am 24. März 2016 23:28:15 MEZ, schrieb Andrew Morton : >> On Thu, 24 Mar 2016 09:38:21 +0100 Denys Vlasenko >> wrote: >> >>> On 03/24/2016 04:03 AM, Zhaoxiu Zeng wrote: >>>> +/* >>>> + * Type invariant interface to the compile time constant parity >> functions. >>>> + */ >>>> +#define PARITY(w) PARITY64((u64)w) >>> >>> Can result in incorrect expansion of w. Should be PARITY64((u64)(w)) >> >> And we seem to be missing the other 30 patches. > Sorry，I got some problems with my gmail.