Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754364AbcC0JJX (ORCPT ); Sun, 27 Mar 2016 05:09:23 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:43784 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751879AbcC0JJN (ORCPT ); Sun, 27 Mar 2016 05:09:13 -0400 Date: Sun, 27 Mar 2016 10:08:59 +0100 From: Mark Brown To: Bjorn Andersson Cc: Krzysztof Kozlowski , Ivaylo Dimitrov , Liam Girdwood , "linux-kernel@vger.kernel.org" , Ulf Hansson , linux-mmc , linux-samsung-soc , Javier Martinez Canillas , Marek Szyprowski Message-ID: <20160327090859.GH5028@sirena.org.uk> References: <1458587912-32665-1-git-send-email-broonie@kernel.org> <1458587912-32665-2-git-send-email-broonie@kernel.org> <56F0624C.8010004@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="N8ia4yKhAKKETby7" Content-Disposition: inline In-Reply-To: X-Cookie: Are you sure the back door is locked? User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] regulator: core: Ensure we are at least in bounds for our constraints X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1420 Lines: 40 --N8ia4yKhAKKETby7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Mar 26, 2016 at 04:50:41PM -0700, Bjorn Andersson wrote: > Reinstating the following snippet in of_get_regulation_constraints() > sort this out: > if (constraints->min_uV && constraints->max_uV) > constraints->apply_uV = true; The existing check in the patch should be an || not an ==, or possibly we should just not bother looking for min_uV at all. I just pushed out a version of that, let's see how that goes. > I did look at an alternative of having regulator_set_voltage() pass > and call set_voltage() if the requested voltage matches the > constraints, but this does indeed seem to mess things up. So checking > in with you before continuing on that hack. Yes, not everything is writeable. --N8ia4yKhAKKETby7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW96MqAAoJECTWi3JdVIfQhd4H/2jPS6G+FM2FtxDs9sQ0JmB+ Xff+TTzJhL5/EzuPbKzc0XLNmezpa3Jj2zCq2lkYzN9aSFw/0/O0qGVsNqbWeINO yxh0Z1SsG/h5j44HrW49R7Er4xpNDd2aInTBqLUXwu7NTD+U/ZHSH/HY3YlR4Vow 4NDlFx3+eojeA4FCIH5cZ6qquMezsssVOI77+lud3GDs3p6QHGwGI5wGI9hRR/Zz udYWSt5NhRXffW2OoNGUnilRjZh6I3zXKnsNG9KKs4/5gHwXOSrHxtnzlaJ5QcdZ 9TOKxsea5COnZDg2LMVOUiDjQ470BJsgydu+93bkXj/KzYkw4LHq1ifc94xj+HM= =rhow -----END PGP SIGNATURE----- --N8ia4yKhAKKETby7--