Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753179AbcC0R4X (ORCPT ); Sun, 27 Mar 2016 13:56:23 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:34964 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752647AbcC0R4W (ORCPT ); Sun, 27 Mar 2016 13:56:22 -0400 Date: Sun, 27 Mar 2016 19:56:15 +0200 From: Sam Ravnborg To: "zhaoxiu.zeng" Cc: Denys Vlasenko , Arnd Bergmann , Andrew Morton , Martin Kepplinger , Sasha Levin , Ingo Molnar , Yury Norov , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 01/31] bitops: add parity functions Message-ID: <20160327175615.GA8864@ravnborg.org> References: <1458788612-4367-1-git-send-email-zhaoxiu.zeng@gmail.com> <56F3A77D.6060802@redhat.com> <56F75490.9010608@gmail.com> <20160327124401.GA7407@ravnborg.org> <56F7E24F.3040306@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56F7E24F.3040306@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=Fo6lhzfq c=1 sm=1 tr=0 a=Ij76tQDYWdb01v2+RnYW5w==:117 a=Ij76tQDYWdb01v2+RnYW5w==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=kj9zAlcOel0A:10 a=gWQy_4Bmy6rIJV7r5ioA:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 342 Lines: 10 > > Any particular reason that you select one approach over the other > > in the different cases? > > No particular reason, just like the architecture's __arch_hweightN. The general recommendatiosn these days are to use static inline for code to get better type check. And it would also be nice to be consistent across architectures. Sam