Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753275AbcC0Vob (ORCPT ); Sun, 27 Mar 2016 17:44:31 -0400 Received: from mail-ig0-f195.google.com ([209.85.213.195]:35257 "EHLO mail-ig0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751629AbcC0Vo3 (ORCPT ); Sun, 27 Mar 2016 17:44:29 -0400 MIME-Version: 1.0 In-Reply-To: <20160327202657.GA31059@amd> References: <20160327202657.GA31059@amd> Date: Mon, 28 Mar 2016 00:44:27 +0300 Message-ID: Subject: Re: usb: gadget breakage on N900: bind UDC by name passed via usb_gadget_driver structure From: Ruslan Bilovol To: Pavel Machek Cc: Marek Szyprowski , pali.rohar@gmail.com, sre@kernel.org, kernel list , linux-arm-kernel , linux-omap , Tony Lindgren , khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, Patrik Bachan , serge@hallyn.com, Maxime Ripard , Peter Chen , Felipe Balbi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1801 Lines: 49 Hi, On Sun, Mar 27, 2016 at 11:26 PM, Pavel Machek wrote: > Hi! > >> >> I managed to boot N900 with working USB gadget (builtin g_ether) >> >> in boardfile mode, can ping it from PC and transfer data. I don't >> >> see any issue (except of musb name issue in twl phy driver, I've >> >> already sent a fix for that: https://lkml.org/lkml/2016/3/24/670 ) >> >> >> >> Pavel, I still don't see how you've got your issue, please share >> >> more detials >> > >> > Ok, let me try. I undid all the changes in drivers/phy drivers/usb and >> > include/linux/usb . I have all the gadget stuff built-in, so that I >> > could use nfsroot, but this is boot from mmcblk. >> >> So do you mean you use original rootfs that was shipeed with N900? > > No. I'm using Debian ARM root. It includes useful X and even phone > functions. https://gitlab.com/tui/tui . > >> > gzipped config is attached. >> >> Thanks, I'll try that > > Thanks. > >> > Dmesg from the n900 is attached as /tmp/delme.gz. I did _not_ apply >> > the patch from https://lkml.org/lkml/2016/3/24/670 , yet, as I'm using >> > devicetree boot. >> >> Hmm.. don't see anything strange in the boot log related to USB, >> I'll try your config > > Let me know how it went. I tried your config (with slight modifications) with vanilla kernel v4.5 (modifications: cmdline changed to default; used INITRAMFS_SOURCE for prebuilt cpio archive with rootfs) and Device Tree booting. Works fine for me except I need to unplug-plug usb cable or issue # echo connect > /sys/devices/platform/68000000.ocp/480ab000 .usb_otg_hs/musb-hdrc.0.auto/udc/musb-hdrc.0.auto/soft_connect to make connection. The gadget driver successfully binds to the gadget, but I don't know why the musb core doesn't issue pullup on USB lines during boot. Best regards, Ruslan