Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753413AbcC1A0k (ORCPT ); Sun, 27 Mar 2016 20:26:40 -0400 Received: from mail-ig0-f181.google.com ([209.85.213.181]:37979 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752441AbcC1A0g (ORCPT ); Sun, 27 Mar 2016 20:26:36 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Sun, 27 Mar 2016 21:26:35 -0300 Message-ID: Subject: Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity From: Fabio Estevam To: =?UTF-8?Q?Krzysztof_Ha=C5=82asa?= , Lucas Stach Cc: =?UTF-8?Q?Petr_=C5=A0tetiar?= , Richard Zhu , Bjorn Helgaas , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 463 Lines: 13 On Sun, Mar 27, 2016 at 11:44 AM, Fabio Estevam wrote: > Good catch! > > Reviewed-by: Fabio Estevam > > I will fix imx6q-sabresd.dtsi when this patch gets applied. After thinking more about it, I think the correct fix is to revert 5c5fb40de8f143 ("PCI: imx6: Add support for active-low reset GPIO") so that we do not break old dtb's. Then a new dt property can be added if someone needs gpio active high PCI reset.