Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753832AbcC1Cjy (ORCPT ); Sun, 27 Mar 2016 22:39:54 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:58829 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753044AbcC1Cjx (ORCPT ); Sun, 27 Mar 2016 22:39:53 -0400 Date: Sun, 27 Mar 2016 22:39:51 -0400 (EDT) Message-Id: <20160327.223951.94101686178513680.davem@davemloft.net> To: romieu@fr.zoreil.com Cc: linux@rasmusvillemoes.dk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: sxgbe: fix error paths in sxgbe_platform_probe() From: David Miller In-Reply-To: <20160327082254.GA10620@electric-eye.fr.zoreil.com> References: <877fgue1mx.fsf@rasmusvillemoes.dk> <1459027449-2667-1-git-send-email-linux@rasmusvillemoes.dk> <20160327082254.GA10620@electric-eye.fr.zoreil.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 27 Mar 2016 19:39:52 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 322 Lines: 8 From: Francois Romieu Date: Sun, 27 Mar 2016 10:22:54 +0200 > Two years after the initial submission, there is zero change regarding use > of sxgbe_core_ops for extension or manageability. The extra indirection is > ripe for removal during next net-next. I completely agree, that stuff has to go.