Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754190AbcC1Cnb (ORCPT ); Sun, 27 Mar 2016 22:43:31 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:58879 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753485AbcC1Cn3 (ORCPT ); Sun, 27 Mar 2016 22:43:29 -0400 Date: Sun, 27 Mar 2016 22:43:27 -0400 (EDT) Message-Id: <20160327.224327.429120851380462276.davem@davemloft.net> To: gabrielcsmo@gmail.com Cc: isdn@linux-pingi.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Drivers: isdn: hisax: isac.c: Fix assignment and check into one expression. From: David Miller In-Reply-To: <1458953390-7306-1-git-send-email-gabrielcsmo@gmail.com> References: <1458953390-7306-1-git-send-email-gabrielcsmo@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 27 Mar 2016 19:43:28 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 252 Lines: 8 From: Cosmin-Gabriel Samoila Date: Sat, 26 Mar 2016 02:49:50 +0200 > Fix variable assignment inside if statement. It is error-prone and hard to read. > > Signed-off-by: Cosmin-Gabriel Samoila Applied.