Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754135AbcC1Cou (ORCPT ); Sun, 27 Mar 2016 22:44:50 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36555 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753044AbcC1Cos (ORCPT ); Sun, 27 Mar 2016 22:44:48 -0400 Subject: Re: [PATCH 01/31] bitops: add parity functions To: Sam Ravnborg References: <1458788612-4367-1-git-send-email-zhaoxiu.zeng@gmail.com> <56F3A77D.6060802@redhat.com> <56F75490.9010608@gmail.com> <20160327124401.GA7407@ravnborg.org> <56F7E24F.3040306@gmail.com> <20160327175615.GA8864@ravnborg.org> Cc: Denys Vlasenko , Arnd Bergmann , Andrew Morton , Martin Kepplinger , Sasha Levin , Ingo Molnar , Yury Norov , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org From: Zeng Zhaoxiu Message-ID: <56F89A9B.10709@gmail.com> Date: Mon, 28 Mar 2016 10:44:43 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160327175615.GA8864@ravnborg.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 529 Lines: 13 OK, I will do the V2 patches soon. In addition, the best is to provide asm version parity functions for powerpc, sparc, and x86. 在 2016年03月28日 01:56, Sam Ravnborg 写道: >>> Any particular reason that you select one approach over the other >>> in the different cases? >> No particular reason, just like the architecture's __arch_hweightN. > The general recommendatiosn these days are to use static inline > for code to get better type check. > And it would also be nice to be consistent across architectures. > > Sam