From: Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com>
To: Soren Brinkmann <sorenb@xilinx.com>
CC: "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "pawel.moll@arm.com" <pawel.moll@arm.com>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
        "galak@codeaurora.org" <galak@codeaurora.org>,
        Michal Simek <michals@xilinx.com>,
        "vinod.koul@intel.com" <vinod.koul@intel.com>,
        "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
        Anurag Kumar Vulisha <anuragku@xilinx.com>,
        "moritz.fischer@ettus.com" <moritz.fischer@ettus.com>,
        "laurent.pinchart@ideasonboard.com" 
	<laurent.pinchart@ideasonboard.com>,
        "luis@debethencourt.com" <luis@debethencourt.com>,
        Srikanth Vemula <svemula@xilinx.com>,
        Anirudha Sarangi <anirudh@xilinx.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Subject: RE: [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for
 AXI CDMA
Thread-Topic: [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for
 AXI CDMA
Thread-Index: AQHRiFNctCSM5eP4Y0C1wFJrW/hXw59tJrMAgAEssCA=
Date: Mon, 28 Mar 2016 05:27:01 +0000
Message-ID: <C246CAC1457055469EF09E3A7AC4E11A4A570609@XAP-PVEXMBX01.xlnx.xilinx.com>
References: <1459101966-9932-1-git-send-email-appanad@xilinx.com>
 <1459101966-9932-2-git-send-email-appanad@xilinx.com>
 <20160327192742.GJ19212@xsjsorenbubuntu>
In-Reply-To: <20160327192742.GJ19212@xsjsorenbubuntu>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2016 05:27:05.6458
 (UTC)
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM02HT042
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u2S5Rfbw007523
Content-Length: 3375
Lines: 87

Hi Soren,

> -----Original Message-----
> From: Sören Brinkmann [mailto:soren.brinkmann@xilinx.com]
> Sent: Monday, March 28, 2016 12:58 AM
> To: Appana Durga Kedareswara Rao
> Cc: robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com;
> ijc+devicetree@hellion.org.uk; galak@codeaurora.org; Michal Simek;
> vinod.koul@intel.com; dan.j.williams@intel.com; Anurag Kumar Vulisha; Appana
> Durga Kedareswara Rao; moritz.fischer@ettus.com;
> laurent.pinchart@ideasonboard.com; luis@debethencourt.com; Srikanth
> Vemula; Anirudha Sarangi; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> dmaengine@vger.kernel.org
> Subject: Re: [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for
> AXI CDMA
> 
> On Sun, 2016-03-27 at 23:36:06 +0530, Kedareswara rao Appana wrote:
> > This patch updates the device-tree binding doc for adding support for
> > AXI CDMA.
> >
> > Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
> > ---
> > ---> Modified commit message as suggested by Vinod.
> > ---> Moved the patch to forward in the series as suggested by vinod.
> >
> >  .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt     | 18
> +++++++++++++++++-
> >  1 file changed, 17 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > index 5841421..2b0c12b 100644
> > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > @@ -8,8 +8,12 @@ target devices. It can be configured to have one channel
> or two channels.
> >  If configured as two channels, one is to transmit to the device and
> > another  is to receive from the device.
> >
> > +Xilinx AXI CDMA engine, it does transfers between memory-mapped
> > +source address and a memory-mapped destination address.
> > +
> >  Required properties:
> > -- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
> > +- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a" or
> > +	      "xlnx,axi-cdma-1.00.a""
> >  - #dma-cells: Should be <1>, see "dmas" property below
> >  - reg: Should contain VDMA registers location and length.
> >  - xlnx,num-fstores: Should be the number of framebuffers as configured in
> h/w.
> > @@ -80,6 +84,18 @@ axi_dma_0: axidma@40400000 {
> >  	} ;
> >  } ;
> >
> > +axi_cdma_0: axicdma@7e200000 {
> > +       compatible = "xlnx,axi-cdma-1.00.a";
> > +       #dma-cells = <1>;
> > +       reg = < 0x7e200000 0x10000 >;
> > +       xlnx,addrwidth = <0x20>;
> > +       dma-channel@7e200000 {
> > +               compatible = "xlnx,axi-dma-mm2s-channel";
> > +               interrupts = < 0 55 4 >;
> > +               xlnx,datawidth = <0x40>;
> > +       } ;
> > +} ;
> 
> As in the other patch, the node name should be 'dma-controller@...' and the
> inconsistend spacing could be fixed.

Ok will fix...

> 
> Also, it seems this adds pretty much identical examples that just differ in the
> compat string. Is that really needed?

Most of the properties are same across the three DMA's
For AXI VDMA there are few required properties that are not required for AXI DMA/CDMA.
That's why added example for the other IP's as well I mean for AXI DMA and CDMA.

Regards,
Kedar.

> 
> 	Sören