Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754577AbcC1GkT (ORCPT ); Mon, 28 Mar 2016 02:40:19 -0400 Received: from regular1.263xmail.com ([211.150.99.135]:50518 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753416AbcC1GkO (ORCPT ); Mon, 28 Mar 2016 02:40:14 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <56F8D1C5.6060504@rock-chips.com> Date: Mon, 28 Mar 2016 14:40:05 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Tomeu Vizoso , linux-kernel@vger.kernel.org CC: David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] drm/rockchip: vop: Don't reject empty modesets References: <1458300123-6397-1-git-send-email-tomeu.vizoso@collabora.com> In-Reply-To: <1458300123-6397-1-git-send-email-tomeu.vizoso@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1013 Lines: 29 On 2016年03月18日 19:22, Tomeu Vizoso wrote: > So that when DRM_IOCTL_MODE_SETCRTC is called without a FB nor mode, the > CRTC gets disabled. > > Signed-off-by: Tomeu Vizoso > Link: http://lkml.kernel.org/g/CAAObsKAv+05ih5U+=4kic_NsjGMhfxYheHR8xXXmacZs+p5SHw@mail.gmail.com > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index fd370548d7d7..5e57f5b2e4b0 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -885,9 +885,6 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc, > { > struct vop *vop = to_vop(crtc); > > - if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0) > - return false; > - > adjusted_mode->clock = > clk_round_rate(vop->dclk, mode->clock * 1000) / 1000; > Applied to my drm-fixes, Thanks. -- Mark Yao