Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754519AbcC1I6k (ORCPT ); Mon, 28 Mar 2016 04:58:40 -0400 Received: from mail-ig0-f195.google.com ([209.85.213.195]:33588 "EHLO mail-ig0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488AbcC1I6j (ORCPT ); Mon, 28 Mar 2016 04:58:39 -0400 MIME-Version: 1.0 In-Reply-To: <1459142821-20303-3-git-send-email-iamjoonsoo.kim@lge.com> References: <1459142821-20303-1-git-send-email-iamjoonsoo.kim@lge.com> <1459142821-20303-3-git-send-email-iamjoonsoo.kim@lge.com> Date: Mon, 28 Mar 2016 10:58:38 +0200 X-Google-Sender-Auth: 63Gl9_lHznv8q6X8_Z20Be6no_8 Message-ID: Subject: Re: [PATCH 02/11] mm/slab: remove BAD_ALIEN_MAGIC again From: Geert Uytterhoeven To: JoonSoo Kim Cc: Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Jesper Dangaard Brouer , Linux MM , "linux-kernel@vger.kernel.org" , Joonsoo Kim Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 30 Hi Jonsoo, On Mon, Mar 28, 2016 at 7:26 AM, wrote: > From: Joonsoo Kim > > Initial attemp to remove BAD_ALIEN_MAGIC is once reverted by > 'commit edcad2509550 ("Revert "slab: remove BAD_ALIEN_MAGIC"")' > because it causes a problem on m68k which has many node > but !CONFIG_NUMA. In this case, although alien cache isn't used > at all but to cope with some initialization path, garbage value > is used and that is BAD_ALIEN_MAGIC. Now, this patch set > use_alien_caches to 0 when !CONFIG_NUMA, there is no initialization > path problem so we don't need BAD_ALIEN_MAGIC at all. So remove it. > > Signed-off-by: Joonsoo Kim I gave this a try on m68k/ARAnyM, and it didn't crash, unlike the previous version that was reverted, so Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds