Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754793AbcC1JJ6 (ORCPT ); Mon, 28 Mar 2016 05:09:58 -0400 Received: from mail-qk0-f179.google.com ([209.85.220.179]:34287 "EHLO mail-qk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754051AbcC1JJ4 (ORCPT ); Mon, 28 Mar 2016 05:09:56 -0400 MIME-Version: 1.0 In-Reply-To: <20160328071351.GC3302@peterchendt> References: <20160325070937.GA22398@peterchendt> <20160328071351.GC3302@peterchendt> Date: Mon, 28 Mar 2016 17:09:54 +0800 Message-ID: Subject: Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation From: Baolin Wang To: Peter Chen Cc: Felipe Balbi , Greg KH , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Peter Chen , Alan Stern , r.baldyga@samsung.com, Yoshihiro Shimoda , Lee Jones , Mark Brown , Charles Keepax , patches@opensource.wolfsonmicro.com, Linux PM list , USB , device-mainlining@lists.linuxfoundation.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1492 Lines: 39 On 28 March 2016 at 15:13, Peter Chen wrote: > On Mon, Mar 28, 2016 at 02:51:40PM +0800, Baolin Wang wrote: >> On 25 March 2016 at 15:09, Peter Chen wrote: >> > On Thu, Mar 24, 2016 at 08:35:53PM +0800, Baolin Wang wrote: >> >> Currently the Linux kernel does not provide any standard integration of this >> >> feature that integrates the USB subsystem with the system power regulation >> >> provided by PMICs meaning that either vendors must add this in their kernels >> >> or USB gadget devices based on Linux (such as mobile phones) may not behave >> >> as they should. Thus provide a standard framework for doing this in kernel. >> >> >> >> Now introduce one user with wm831x_power to support and test the usb charger, >> >> which is pending testing. Moreover there may be other potential users will use >> >> it in future. >> >> >> > >> > I am afraid I still not find the user (udc driver) for this framework, I would >> > like to see how udc driver block the enumeration until the charger detection >> > has finished, or am I missing something? >> >> It is not for udc driver but for power users who want to negotiate >> with USB subsystem. >> > > Then, where is the code the test user to decide what kinds of USB charger > (SDP, CDP, DCP) is connecting now? Users can choose to implement multiple ways to get the charger type In 'usb_charger_detect_type()' function. > > -- > Best Regards, > Peter Chen -- Baolin.wang Best Regards