Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754911AbcC1Jyi (ORCPT ); Mon, 28 Mar 2016 05:54:38 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:44539 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751854AbcC1Jyg (ORCPT ); Mon, 28 Mar 2016 05:54:36 -0400 Subject: Re: [PATCH 3/6] iio: gyro: bmg160: use available_scan_masks To: Irina Tirdea , linux-iio@vger.kernel.org References: <1458811771-25217-1-git-send-email-irina.tirdea@intel.com> <1458811771-25217-4-git-send-email-irina.tirdea@intel.com> Cc: linux-kernel@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Octavian Purdila , Markus Pargmann , Srinivas Pandruvada From: Jonathan Cameron Message-ID: <56F8FF5A.6000405@kernel.org> Date: Mon, 28 Mar 2016 10:54:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1458811771-25217-4-git-send-email-irina.tirdea@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1822 Lines: 56 On 24/03/16 09:29, Irina Tirdea wrote: > Use available_scan_masks to allow the iio core to select > the data to send to userspace depending on which axes are > enabled, instead of doing this in the driver's interrupt > handler. > > Signed-off-by: Irina Tirdea Applied, Thanks, > --- > drivers/iio/gyro/bmg160_core.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/gyro/bmg160_core.c b/drivers/iio/gyro/bmg160_core.c > index bbce3b0..8d6e5b1 100644 > --- a/drivers/iio/gyro/bmg160_core.c > +++ b/drivers/iio/gyro/bmg160_core.c > @@ -116,6 +116,7 @@ enum bmg160_axis { > AXIS_X, > AXIS_Y, > AXIS_Z, > + AXIS_MAX, > }; > > static const struct { > @@ -763,6 +764,10 @@ static const struct iio_info bmg160_info = { > .driver_module = THIS_MODULE, > }; > > +static const unsigned long bmg160_accel_scan_masks[] = { > + BIT(AXIS_X) | BIT(AXIS_Y) | BIT(AXIS_Z), > + 0}; > + > static irqreturn_t bmg160_trigger_handler(int irq, void *p) > { > struct iio_poll_func *pf = p; > @@ -772,8 +777,7 @@ static irqreturn_t bmg160_trigger_handler(int irq, void *p) > unsigned int val; > > mutex_lock(&data->mutex); > - for_each_set_bit(bit, indio_dev->active_scan_mask, > - indio_dev->masklength) { > + for (bit = 0; bit < AXIS_MAX; bit++) { > ret = regmap_bulk_read(data->regmap, BMG160_AXIS_TO_REG(bit), > &val, 2); > if (ret < 0) { > @@ -1019,6 +1023,7 @@ int bmg160_core_probe(struct device *dev, struct regmap *regmap, int irq, > indio_dev->channels = bmg160_channels; > indio_dev->num_channels = ARRAY_SIZE(bmg160_channels); > indio_dev->name = name; > + indio_dev->available_scan_masks = bmg160_accel_scan_masks; > indio_dev->modes = INDIO_DIRECT_MODE; > indio_dev->info = &bmg160_info; > >