Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754884AbcC1J6T (ORCPT ); Mon, 28 Mar 2016 05:58:19 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:44566 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752381AbcC1J6R (ORCPT ); Mon, 28 Mar 2016 05:58:17 -0400 Subject: Re: [PATCH 5/6] iio: accel: kxcjk-1013: use available_scan_masks To: Irina Tirdea , linux-iio@vger.kernel.org References: <1458811771-25217-1-git-send-email-irina.tirdea@intel.com> <1458811771-25217-6-git-send-email-irina.tirdea@intel.com> Cc: linux-kernel@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Octavian Purdila , Markus Pargmann , Srinivas Pandruvada , Adriana Reus From: Jonathan Cameron Message-ID: <56F90037.9000101@kernel.org> Date: Mon, 28 Mar 2016 10:58:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1458811771-25217-6-git-send-email-irina.tirdea@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2000 Lines: 59 On 24/03/16 09:29, Irina Tirdea wrote: > From: Adriana Reus > > Use available_scan_masks to allow the iio core to select > the data to send to userspace depending on which axes are > enabled, instead of doing this in the driver's interrupt > handler. > > Signed-off-by: Adriana Reus > Signed-off-by: Irina Tirdea > Acked-by: Jonathan Cameron > Acked-by: Srinivas Pandruvada Applied, thanks, Jonathan > --- > drivers/iio/accel/kxcjk-1013.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c > index edec1d0..3861fe9 100644 > --- a/drivers/iio/accel/kxcjk-1013.c > +++ b/drivers/iio/accel/kxcjk-1013.c > @@ -115,6 +115,7 @@ enum kxcjk1013_axis { > AXIS_X, > AXIS_Y, > AXIS_Z, > + AXIS_MAX, > }; > > enum kxcjk1013_mode { > @@ -953,6 +954,8 @@ static const struct iio_info kxcjk1013_info = { > .driver_module = THIS_MODULE, > }; > > +static const unsigned long kxcjk1013_scan_masks[] = {0x7, 0}; > + > static irqreturn_t kxcjk1013_trigger_handler(int irq, void *p) > { > struct iio_poll_func *pf = p; > @@ -962,8 +965,7 @@ static irqreturn_t kxcjk1013_trigger_handler(int irq, void *p) > > mutex_lock(&data->mutex); > > - for_each_set_bit(bit, indio_dev->active_scan_mask, > - indio_dev->masklength) { > + for (bit = 0; bit < AXIS_MAX; bit++) { > ret = kxcjk1013_get_acc_reg(data, bit); > if (ret < 0) { > mutex_unlock(&data->mutex); > @@ -1204,6 +1206,7 @@ static int kxcjk1013_probe(struct i2c_client *client, > indio_dev->dev.parent = &client->dev; > indio_dev->channels = kxcjk1013_channels; > indio_dev->num_channels = ARRAY_SIZE(kxcjk1013_channels); > + indio_dev->available_scan_masks = kxcjk1013_scan_masks; > indio_dev->name = name; > indio_dev->modes = INDIO_DIRECT_MODE; > indio_dev->info = &kxcjk1013_info; >