Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754845AbcC1J7i (ORCPT ); Mon, 28 Mar 2016 05:59:38 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:44576 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbcC1J7g (ORCPT ); Mon, 28 Mar 2016 05:59:36 -0400 Subject: Re: [PATCH 6/6] iio: accel: kxcjk-1013: optimize i2c transfers in trigger handler To: Irina Tirdea , linux-iio@vger.kernel.org References: <1458811771-25217-1-git-send-email-irina.tirdea@intel.com> <1458811771-25217-7-git-send-email-irina.tirdea@intel.com> Cc: linux-kernel@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Octavian Purdila , Markus Pargmann , Srinivas Pandruvada , Adriana Reus From: Jonathan Cameron Message-ID: <56F90086.1080506@kernel.org> Date: Mon, 28 Mar 2016 10:59:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1458811771-25217-7-git-send-email-irina.tirdea@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2612 Lines: 72 On 24/03/16 09:29, Irina Tirdea wrote: > From: Adriana Reus > > Some i2c busses (e.g.: Synopsys DesignWare I2C adapter) need to > enable/disable the bus at each i2c transfer and must wait for > the enable/disable to happen before sending the data. > > When reading data in the trigger handler, the kxcjk-1013 accel driver > does one i2c transfer for each axis. This has an impact on the > frequency of the accelerometer at high sample rates due to additional > delays introduced by the i2c bus at each transfer. > > Reading all axis values in one i2c transfer reduces the delays > introduced by the i2c bus. Uses i2c_smbus_read_i2c_block_data_or_emulated > that will fallback to reading each axis as a separate word in case i2c > block read is not supported. > > Signed-off-by: Adriana Reus > Signed-off-by: Irina Tirdea > Acked-by: Jonathan Cameron > Acked-by: Srinivas Pandruvada Applied - with all the others to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/accel/kxcjk-1013.c | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) > > diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c > index 3861fe9..4881856 100644 > --- a/drivers/iio/accel/kxcjk-1013.c > +++ b/drivers/iio/accel/kxcjk-1013.c > @@ -923,7 +923,7 @@ static const struct iio_event_spec kxcjk1013_event = { > .realbits = 12, \ > .storagebits = 16, \ > .shift = 4, \ > - .endianness = IIO_CPU, \ > + .endianness = IIO_LE, \ > }, \ > .event_spec = &kxcjk1013_event, \ > .num_event_specs = 1 \ > @@ -961,19 +961,16 @@ static irqreturn_t kxcjk1013_trigger_handler(int irq, void *p) > struct iio_poll_func *pf = p; > struct iio_dev *indio_dev = pf->indio_dev; > struct kxcjk1013_data *data = iio_priv(indio_dev); > - int bit, ret, i = 0; > + int ret; > > mutex_lock(&data->mutex); > - > - for (bit = 0; bit < AXIS_MAX; bit++) { > - ret = kxcjk1013_get_acc_reg(data, bit); > - if (ret < 0) { > - mutex_unlock(&data->mutex); > - goto err; > - } > - data->buffer[i++] = ret; > - } > + ret = i2c_smbus_read_i2c_block_data_or_emulated(data->client, > + KXCJK1013_REG_XOUT_L, > + AXIS_MAX * 2, > + (u8 *)data->buffer); > mutex_unlock(&data->mutex); > + if (ret < 0) > + goto err; > > iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, > data->timestamp); >