Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754902AbcC1L4L (ORCPT ); Mon, 28 Mar 2016 07:56:11 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36333 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753294AbcC1L4I convert rfc822-to-8bit (ORCPT ); Mon, 28 Mar 2016 07:56:08 -0400 MIME-Version: 1.0 In-Reply-To: <1457537342-678-2-git-send-email-emilio.lopez@collabora.co.uk> References: <1457537342-678-1-git-send-email-emilio.lopez@collabora.co.uk> <1457537342-678-2-git-send-email-emilio.lopez@collabora.co.uk> Date: Mon, 28 Mar 2016 12:56:06 +0100 Message-ID: Subject: Re: [RFC PATCH v1 1/9] selftest: sync: basic tests for sw_sync framework From: Emil Velikov To: =?UTF-8?Q?Emilio_L=C3=B3pez?= Cc: Shuah Khan , devel@driverdev.osuosl.org, Daniel Stone , Daniel Vetter , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , Riley Andrews , linux-kselftest@vger.kernel.org, Gustavo Padovan , John Harrison Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 811 Lines: 21 Hi Emilio, On 9 March 2016 at 15:28, Emilio López wrote: > These tests are based on the libsync test suite from Android. > This commit lays the ground for future tests, as well as includes > tests for a variety of basic allocation commands. > > Signed-off-by: Gustavo Padovan > Signed-off-by: Emilio López > --- > > tools/testing/selftests/sync/sync.h | 119 ++++++++++++++++++ Admittedly I know nothing about the kernel selftests although copying the UAPI header, seems to defeat the purpose of this exercise. Shouldn't one reuse the existing header ? It would even cause issues as the interface gets updated (iirc Gustavo changed the ioctl numbers and/or header name with latter series). Regards, Emil