Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755177AbcC1MwX (ORCPT ); Mon, 28 Mar 2016 08:52:23 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:42232 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755152AbcC1MwU (ORCPT ); Mon, 28 Mar 2016 08:52:20 -0400 Subject: Re: [RFC PATCH v1 9/9] selftest: sync: disable tests that rely on not yet defined behaviour To: Shuah Khan References: <1457537342-678-1-git-send-email-emilio.lopez@collabora.co.uk> <1457537342-678-10-git-send-email-emilio.lopez@collabora.co.uk> <56E04BD6.9050502@osg.samsung.com> Cc: devel@driverdev.osuosl.org, Gustavo Padovan , Riley Andrews , Daniel Vetter , John Harrison , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Greg Hackmann , Rob Clark , linux-kselftest@vger.kernel.org, Maarten Lankhorst , Daniel Stone , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= From: =?UTF-8?Q?Emilio_L=c3=b3pez?= Message-ID: <56F9248D.70100@collabora.co.uk> Date: Mon, 28 Mar 2016 09:33:17 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E04BD6.9050502@osg.samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1399 Lines: 37 El 09/03/16 a las 13:14, Shuah Khan escribió: > On 03/09/2016 08:29 AM, Emilio López wrote: >> One of the tests rely on a behaviour only observed on the driver currently >> in use in Android. Disable it here until the behaviour is implemented >> or it is decided it should not be implemented on the driver in mainline. >> >> Signed-off-by: Emilio López >> >> --- >> >> tools/testing/selftests/sync/sync_test.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/tools/testing/selftests/sync/sync_test.c b/tools/testing/selftests/sync/sync_test.c >> index c3e4c01..3f484318 100644 >> --- a/tools/testing/selftests/sync/sync_test.c >> +++ b/tools/testing/selftests/sync/sync_test.c >> @@ -66,7 +66,14 @@ int main(void) >> err += RUN_TEST(test_fence_one_timeline_merge); >> err += RUN_TEST(test_fence_merge_same_fence); >> err += RUN_TEST(test_fence_multi_timeline_wait); >> +#if 0 >> + /* The following test has been disabled due to differences >> + * between the upstream and Android kernel drivers. The behaviour >> + * that should occur when destroying a timeline with active fences >> + * has not been defined yet. >> + */ >> err += RUN_TEST(test_fence_wait_on_destroyed_timeline); >> +#endif > > It would be useful to have a real define here that can be > enabled later easily instead of if 0. Ok, sounds good. Thanks! Emilio