Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754577AbcC1OeE (ORCPT ); Mon, 28 Mar 2016 10:34:04 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37750 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754235AbcC1Ody convert rfc822-to-8bit (ORCPT ); Mon, 28 Mar 2016 10:33:54 -0400 From: Michal Nazarewicz To: "zhaoxiu.zeng" , Jiri Pirko , Andrew Morton , "David S. Miller" , Vlastimil Babka , Joonsoo Kim Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 25/31] ethernet: use parity8 in sun/niu.c In-Reply-To: <56F78D76.1060305@gmail.com> Organization: http://mina86.com/ References: <1458788612-4367-1-git-send-email-zhaoxiu.zeng@gmail.com> <56F78D76.1060305@gmail.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:160328:davem@davemloft.net::1cIDSNFoIKG/hoJz:0000000000000000000000000000000000000000000nhx X-Hashcash: 1:20:160328:iamjoonsoo.kim@lge.com::6ZCMwDSqXfJODA4J:0000000000000000000000000000000000000001NXu X-Hashcash: 1:20:160328:jiri@resnulli.us::1RML2mtU4iTM2wvF:02HZM X-Hashcash: 1:20:160328:netdev@vger.kernel.org::LmpTfu0cV1Ku3BNK:0000000000000000000000000000000000000002Svd X-Hashcash: 1:20:160328:linux-kernel@vger.kernel.org::H0Wgjaj5q9LBMZ0n:0000000000000000000000000000000004LdZ X-Hashcash: 1:20:160328:vbabka@suse.cz::xYyCZO7KhisuQoDG:0004bCt X-Hashcash: 1:20:160328:akpm@linux-foundation.org::nKKo99LQxRkvlizh:0000000000000000000000000000000000008t4U X-Hashcash: 1:20:160328:zhaoxiu.zeng@gmail.com::uJFatFkP+MbLH4Dr:0000000000000000000000000000000000000006Mri Date: Mon, 28 Mar 2016 10:33:48 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1289 Lines: 46 On Sun, Mar 27 2016, zhaoxiu zeng wrote: > From: Zeng Zhaoxiu > > Signed-off-by: Zeng Zhaoxiu No idea why I’ve been CC’d, but code looks good to me so: Acked-by: Michal Nazarewicz > --- > drivers/net/ethernet/sun/niu.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c > index 9cc4564..8c344ef 100644 > --- a/drivers/net/ethernet/sun/niu.c > +++ b/drivers/net/ethernet/sun/niu.c > @@ -2742,18 +2742,12 @@ static int niu_set_alt_mac_rdc_table(struct niu *np, int idx, > > static u64 vlan_entry_set_parity(u64 reg_val) > { > - u64 port01_mask; > - u64 port23_mask; > - > - port01_mask = 0x00ff; > - port23_mask = 0xff00; > - > - if (hweight64(reg_val & port01_mask) & 1) > + if (parity8(reg_val)) > reg_val |= ENET_VLAN_TBL_PARITY0; > else > reg_val &= ~ENET_VLAN_TBL_PARITY0; > > - if (hweight64(reg_val & port23_mask) & 1) > + if (parity8((unsigned int)reg_val >> 8)) > reg_val |= ENET_VLAN_TBL_PARITY1; > else > reg_val &= ~ENET_VLAN_TBL_PARITY1; > -- > 2.5.5 > -- Best regards ミハウ “????????????????86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»