Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754026AbcC1POb (ORCPT ); Mon, 28 Mar 2016 11:14:31 -0400 Received: from mail-vk0-f54.google.com ([209.85.213.54]:35528 "EHLO mail-vk0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752665AbcC1PO1 (ORCPT ); Mon, 28 Mar 2016 11:14:27 -0400 MIME-Version: 1.0 In-Reply-To: <1457388054-23077-2-git-send-email-dianders@chromium.org> References: <1457388054-23077-1-git-send-email-dianders@chromium.org> <1457388054-23077-2-git-send-email-dianders@chromium.org> Date: Mon, 28 Mar 2016 08:14:26 -0700 X-Google-Sender-Auth: BsK3LiptrbSFngCd0ymHFMeaQ20 Message-ID: Subject: Re: [PATCH v2 2/5] drm/imx: dw_hdmi: Call drm_encoder_cleanup() in error path From: Doug Anderson To: Russell King , Philipp Zabel Cc: Daniel Kurtz , "open list:ARM/Rockchip SoC..." , John Keeping , Douglas Anderson , "dri-devel@lists.freedesktop.org" , Mark Yao , "linux-kernel@vger.kernel.org" , David Airlie , Heiko Stuebner Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1153 Lines: 35 Hi, On Mon, Mar 7, 2016 at 2:00 PM, Douglas Anderson wrote: > The drm_encoder_cleanup() was missing both from the error path of > dw_hdmi_imx_bind(). This caused a crash when slub_debug was > enabled and we ended up deferring probe of HDMI at boot. > > This call isn't needed from unbind() because if dw_hdmi_bind() returns > no error then it takes over the job of freeing the encoder (in > dw_hdmi_unbind). > > Signed-off-by: Douglas Anderson > --- > Changes in v2: > - IMX patch new in v2 > > drivers/gpu/drm/imx/dw_hdmi-imx.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) Mark picked up: [PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path [PATCH v2 3/5] drm/rockchip: vop: Fix vop crtc cleanup [PATCH v2 4/5] drm/rockchip: dw_hdmi: Don't call platform_set_drvdata() ...for Rockchip, as you can see at . Does someone want to pick up: [PATCH v2 2/5] drm/imx: dw_hdmi: Call drm_encoder_cleanup() in error path [PATCH v2 5/5] drm/imx: dw_hdmi: Don't call platform_set_drvdata() Thanks! -Doug