Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755254AbcC1T7s (ORCPT ); Mon, 28 Mar 2016 15:59:48 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:36463 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753045AbcC1T7q (ORCPT ); Mon, 28 Mar 2016 15:59:46 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 28 Mar 2016 12:59:45 -0700 Message-ID: Subject: Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity From: Tim Harvey To: Fabio Estevam Cc: =?UTF-8?Q?Krzysztof_Ha=C5=82asa?= , Lucas Stach , =?UTF-8?Q?Petr_=C5=A0tetiar?= , Richard Zhu , Bjorn Helgaas , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1024 Lines: 28 On Sun, Mar 27, 2016 at 5:26 PM, Fabio Estevam wrote: > On Sun, Mar 27, 2016 at 11:44 AM, Fabio Estevam wrote: > >> Good catch! >> >> Reviewed-by: Fabio Estevam >> >> I will fix imx6q-sabresd.dtsi when this patch gets applied. > > After thinking more about it, I think the correct fix is to revert > 5c5fb40de8f143 ("PCI: imx6: Add support for active-low reset GPIO") so > that we do not break old dtb's. > > Then a new dt property can be added if someone needs gpio active high PCI reset. > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Fabio, I would agree with you on this - 5c5fb40de8f143 ("PCI: imx6: Add support for active-low reset GPIO") should be reverted. I just finished bisecting an issue to this specific patch only to find out Krzysztof found it a few days ago ;) Thanks Krzysztof. Tim