Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755352AbcC1Umg (ORCPT ); Mon, 28 Mar 2016 16:42:36 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:33516 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752314AbcC1Ume (ORCPT ); Mon, 28 Mar 2016 16:42:34 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 28 Mar 2016 13:42:33 -0700 Message-ID: Subject: Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity From: Tim Harvey To: Fabio Estevam Cc: =?UTF-8?Q?Krzysztof_Ha=C5=82asa?= , Lucas Stach , =?UTF-8?Q?Petr_=C5=A0tetiar?= , Richard Zhu , Bjorn Helgaas , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1112 Lines: 30 On Mon, Mar 28, 2016 at 1:13 PM, Fabio Estevam wrote: > Hi Tim, > > On Mon, Mar 28, 2016 at 4:59 PM, Tim Harvey wrote: > >> Fabio, >> >> I would agree with you on this - 5c5fb40de8f143 ("PCI: imx6: Add >> support for active-low reset GPIO") should be reverted. >> >> I just finished bisecting an issue to this specific patch only to find >> out Krzysztof found it a few days ago ;) Thanks Krzysztof. > > I sent the revert patch yesterday: > http://marc.info/?l=linux-pci&m=145912622805757&w=2 Fabio, ok - I'll respond there as I agree with the patch but not the wording of the commit (It's Gateworks 'Ventana' using IMX6 not Laguna and we do define the polarity properly as active-low in Ventana dt's). It is the fact that the gpio polarity has the wrong logic level that breaks Ventana. However, there seems to be another regression in 4.5 that's keeping PCI working for me and I'm still bisecting that (using 802.11n access points to test). Can you confirm that PCI works in v4.5 on IMX6 boards with only 5c5fb40de8f14391a1238db05cef88754faf9229 reverted? Tim