Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754754AbcC1UoN (ORCPT ); Mon, 28 Mar 2016 16:44:13 -0400 Received: from smtp-outbound-2.vmware.com ([208.91.2.13]:40991 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245AbcC1UoK (ORCPT ); Mon, 28 Mar 2016 16:44:10 -0400 From: Nadav Amit To: Andrew Morton CC: "linux-mm@kvack.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "mgorman@suse.de" , "sasha.levin@oracle.com" , "riel@redhat.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "kirill.shutemov@linux.intel.com" , "mhocko@suse.com" , "jmarchan@redhat.com" , "hughd@google.com" , "vdavydov@virtuozzo.com" , "minchan@kernel.org" , "linux-kernel@vger.kernel.org" , Mel Gorman Subject: Re: [PATCH v2 1/2] x86/mm: TLB_REMOTE_SEND_IPI should count pages Thread-Topic: [PATCH v2 1/2] x86/mm: TLB_REMOTE_SEND_IPI should count pages Thread-Index: AQHRiRDjQsN3eT76L0CjnYiKGRsSY59vxsSA//+MP4A= Date: Mon, 28 Mar 2016 20:44:07 +0000 Message-ID: <64432900-43CA-4D72-A041-44B0F40DBE88@vmware.com> References: <1458980705-121507-1-git-send-email-namit@vmware.com> <1458980705-121507-2-git-send-email-namit@vmware.com> <20160328133825.210d00fd4af7c7b7039a44c7@linux-foundation.org> In-Reply-To: <20160328133825.210d00fd4af7c7b7039a44c7@linux-foundation.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.113.170.11] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u2SKiI0n010345 Content-Length: 539 Lines: 19 On 3/28/16, 1:38 PM, "Andrew Morton" wrote: >On Sat, 26 Mar 2016 01:25:04 -0700 Nadav Amit wrote: > >> TLB_REMOTE_SEND_IPI was recently introduced, but it counts bytes instead >> of pages. In addition, it does not report correctly the case in which >> flush_tlb_page flushes a page. Fix it to be consistent with other TLB >> counters. >> >> Fixes: 4595f9620cda8a1e973588e743cf5f8436dd20c6 > >I think you mean 5b74283ab251b9 ("x86, mm: trace when an IPI is about >to be sent")? Indeed.