Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755469AbcC1Vdm (ORCPT ); Mon, 28 Mar 2016 17:33:42 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:41065 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752252AbcC1Vdi (ORCPT ); Mon, 28 Mar 2016 17:33:38 -0400 Date: Mon, 28 Mar 2016 23:33:35 +0200 From: Pavel Machek To: Ruslan Bilovol Cc: Marek Szyprowski , pali.rohar@gmail.com, sre@kernel.org, kernel list , linux-arm-kernel , linux-omap , Tony Lindgren , khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, Patrik Bachan , serge@hallyn.com, Maxime Ripard , Peter Chen , Felipe Balbi Subject: Re: usb: gadget breakage on N900: bind UDC by name passed via usb_gadget_driver structure Message-ID: <20160328213334.GA10849@amd> References: <20160327202657.GA31059@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2892 Lines: 70 Hi! > >> >> I managed to boot N900 with working USB gadget (builtin g_ether) > >> >> in boardfile mode, can ping it from PC and transfer data. I don't > >> >> see any issue (except of musb name issue in twl phy driver, I've > >> >> already sent a fix for that: https://lkml.org/lkml/2016/3/24/670 ) > >> >> > >> >> Pavel, I still don't see how you've got your issue, please share > >> >> more detials > >> > > >> > Ok, let me try. I undid all the changes in drivers/phy drivers/usb and > >> > include/linux/usb . I have all the gadget stuff built-in, so that I > >> > could use nfsroot, but this is boot from mmcblk. > >> > >> So do you mean you use original rootfs that was shipeed with N900? > > > > No. I'm using Debian ARM root. It includes useful X and even phone > > functions. https://gitlab.com/tui/tui . > > > >> > gzipped config is attached. > >> > >> Thanks, I'll try that > > > > Thanks. > > > >> > Dmesg from the n900 is attached as /tmp/delme.gz. I did _not_ apply > >> > the patch from https://lkml.org/lkml/2016/3/24/670 , yet, as I'm using > >> > devicetree boot. > >> > >> Hmm.. don't see anything strange in the boot log related to USB, > >> I'll try your config > > > > Let me know how it went. > > I tried your config (with slight modifications) with vanilla kernel v4.5 > (modifications: cmdline changed to default; used INITRAMFS_SOURCE > for prebuilt cpio archive with rootfs) and Device Tree booting. > Works fine for me except I need to unplug-plug usb cable or issue > # echo connect > /sys/devices/platform/68000000.ocp/480ab000 > .usb_otg_hs/musb-hdrc.0.auto/udc/musb-hdrc.0.auto/soft_connect > to make connection. > The gadget driver successfully binds to the gadget, but I don't know > why the musb core doesn't issue pullup on USB lines during boot. I did a quick test here, and unplug/replug does not help, I still get error message on my PC. [53907.784294] usb usb4-port1: unable to enumerate USB device [53990.480064] usb 1-5: new high-speed USB device number 27 using ehci-pci [53990.592036] usb 1-5: device descriptor read/64, error -32 [53990.808092] usb 1-5: device descriptor read/64, error -32 [53991.024042] usb 1-5: new high-speed USB device number 28 using ehci-pci [53991.136043] usb 1-5: device descriptor read/64, error -32 [53991.352041] usb 1-5: device descriptor read/64, error -32 [53991.568076] usb 1-5: new high-speed USB device number 29 using ehci-pci [53991.589955] usb 1-5: device descriptor read/8, error -32 [53991.709703] usb 1-5: device descriptor read/8, error -32 [53991.924577] usb 1-5: new high-speed USB device number 30 using ehci-pci [53991.944944] usb 1-5: device descriptor read/8, error -32 [53992.065822] usb 1-5: device descriptor read/8, error -32 Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html