Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755500AbcC2BDV (ORCPT ); Mon, 28 Mar 2016 21:03:21 -0400 Received: from resqmta-po-06v.sys.comcast.net ([96.114.154.165]:59741 "EHLO resqmta-po-06v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbcC2BDT (ORCPT ); Mon, 28 Mar 2016 21:03:19 -0400 Date: Mon, 28 Mar 2016 20:03:16 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: js1304@gmail.com cc: Andrew Morton , Pekka Enberg , David Rientjes , Jesper Dangaard Brouer , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim Subject: Re: [PATCH 06/11] mm/slab: don't keep free slabs if free_objects exceeds free_limit In-Reply-To: <1459142821-20303-7-git-send-email-iamjoonsoo.kim@lge.com> Message-ID: References: <1459142821-20303-1-git-send-email-iamjoonsoo.kim@lge.com> <1459142821-20303-7-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 926 Lines: 20 On Mon, 28 Mar 2016, js1304@gmail.com wrote: > From: Joonsoo Kim > > Currently, determination to free a slab is done whenever free object is > put into the slab. This has a problem that free slabs are not freed > even if we have free slabs and have more free_objects than free_limit There needs to be a better explanation here since I do not get why there is an issue with checking after free if a slab is actually free. > when processed slab isn't a free slab. This would cause to keep > too much memory in the slab subsystem. This patch try to fix it > by checking number of free object after all free work is done. If there > is free slab at that time, we can free it so we keep free slab as minimal > as possible. Ok if we check after free work is done then the number of free slabs may be higher than the limit set and then we free the additional slabs to get down to the limit that was set?