Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755787AbcC2Ejs (ORCPT ); Tue, 29 Mar 2016 00:39:48 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:33552 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751974AbcC2Ejr (ORCPT ); Tue, 29 Mar 2016 00:39:47 -0400 Date: Mon, 28 Mar 2016 21:39:42 -0700 From: Alexei Starovoitov To: Wang Nan Cc: Alexei Starovoitov , Arnaldo Carvalho de Melo , Peter Zijlstra , linux-kernel@vger.kernel.org, Brendan Gregg , He Kuang , Jiri Olsa , Masami Hiramatsu , Namhyung Kim , pi3orama@163.com, Zefan Li Subject: Re: [PATCH 1/4 fix] perf core: Introduce new ioctl options to pause and resume ring buffer Message-ID: <20160329043940.GA9017@ast-mbp.thefacebook.com> References: <20160329002724.GB31198@ast-mbp.thefacebook.com> <1459217107-244486-1-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459217107-244486-1-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1351 Lines: 32 On Tue, Mar 29, 2016 at 02:05:07AM +0000, Wang Nan wrote: > Add new ioctl() to pause/resume ring-buffer output. > > In some situations we want to read from ring buffer only when we > ensure nothing can write to the ring buffer during reading. Without > this patch we have to turn off all events attached to this ring buffer > to achieve this. > > This patch is for supporting overwrite ring buffer. Following > commits will introduce new methods support reading from overwrite ring > buffer. Before reading, caller must ensure the ring buffer is frozen, or > the reading is unreliable. > > Signed-off-by: Wang Nan > Cc: He Kuang > Cc: Alexei Starovoitov > Cc: Arnaldo Carvalho de Melo > Cc: Brendan Gregg > Cc: Jiri Olsa > Cc: Masami Hiramatsu > Cc: Namhyung Kim > Cc: Peter Zijlstra > Cc: Zefan Li > Cc: pi3orama@163.com > --- > include/uapi/linux/perf_event.h | 1 + > kernel/events/core.c | 13 +++++++++++++ > kernel/events/internal.h | 11 +++++++++++ > kernel/events/ring_buffer.c | 7 ++++++- > 4 files changed, 31 insertions(+), 1 deletion(-) Acked-by: Alexei Starovoitov