Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756169AbcC2GKg (ORCPT ); Tue, 29 Mar 2016 02:10:36 -0400 Received: from webbox1416.server-home.net ([77.236.96.61]:55370 "EHLO webbox1416.server-home.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756000AbcC2GKb (ORCPT ); Tue, 29 Mar 2016 02:10:31 -0400 From: Alexander Stein To: Mark Brown Cc: linux-kernel@vger.kernel.org, Stefan Agner Subject: Re: [PATCH] regmap: mmio: Fix value endianness selection Date: Tue, 29 Mar 2016 08:10:18 +0200 Message-ID: <2467072.5nNY07Ee9z@ws-stein> User-Agent: KMail/4.14.10 (Linux/4.1.15-gentoo-r1; KDE/4.14.16; x86_64; ; ) In-Reply-To: <20160325112459.GD2566@sirena.org.uk> References: <1458739079-11712-1-git-send-email-broonie@kernel.org> <2609570.vvhKhym0nL@ws-stein> <20160325112459.GD2566@sirena.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 779 Lines: 17 On Friday 25 March 2016 11:24:59, Mark Brown wrote: > On Wed, Mar 23, 2016 at 03:20:46PM +0100, Alexander Stein wrote: > > The difference in those drivers is that syscon manually sets > > config.val_format_endian before calling regmap_init_mmio. > > spi-fsl-dspi does not. I guess this driver relies on this configuration > > being done in regmap_get_val_endian. But this is never reached because > > after setting > Does this IP exist in configurations where it is anything other than big > endian? If not then this probably shouldn't be in DT. AFAIK it is included once or twice in the VFxxx series. CC'ed Stefan Agner for confirmation. Stefan: Is the DCU on VFxxx attached little-endian, e.g. no byte swapping needed when accessing the periphery? Best regards, Alexander