Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755935AbcC2GOU (ORCPT ); Tue, 29 Mar 2016 02:14:20 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:36754 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbcC2GOR (ORCPT ); Tue, 29 Mar 2016 02:14:17 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Mon, 28 Mar 2016 23:11:09 -0700 From: Stefan Agner To: Alexander Stein Cc: Mark Brown , linux-kernel@vger.kernel.org Subject: Re: [PATCH] regmap: mmio: Fix value endianness selection In-Reply-To: <2467072.5nNY07Ee9z@ws-stein> References: <1458739079-11712-1-git-send-email-broonie@kernel.org> <2609570.vvhKhym0nL@ws-stein> <20160325112459.GD2566@sirena.org.uk> <2467072.5nNY07Ee9z@ws-stein> Message-ID: <8f62d6ec611e646449ed6fbba197c6f1@agner.ch> User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 21 On 2016-03-28 23:10, Alexander Stein wrote: > On Friday 25 March 2016 11:24:59, Mark Brown wrote: >> On Wed, Mar 23, 2016 at 03:20:46PM +0100, Alexander Stein wrote: >> > The difference in those drivers is that syscon manually sets >> > config.val_format_endian before calling regmap_init_mmio. >> > spi-fsl-dspi does not. I guess this driver relies on this configuration >> > being done in regmap_get_val_endian. But this is never reached because >> > after setting >> Does this IP exist in configurations where it is anything other than big >> endian? If not then this probably shouldn't be in DT. > > AFAIK it is included once or twice in the VFxxx series. CC'ed Stefan Agner for > confirmation. > Stefan: Is the DCU on VFxxx attached little-endian, e.g. no byte swapping > needed when accessing the periphery? Yes, DCU as well as DSPI is attached little endian on Vybrid (aka. vf610). -- Stefan