Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755937AbcC2HN6 (ORCPT ); Tue, 29 Mar 2016 03:13:58 -0400 Received: from hotel311.server4you.de ([85.25.146.15]:55800 "EHLO hotel311.server4you.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752696AbcC2HN4 (ORCPT ); Tue, 29 Mar 2016 03:13:56 -0400 Subject: Re: [PATCH] scripts/gdb: Fix loading of modules information To: Jan Kiszka References: <1459233699-5541-1-git-send-email-wagi@monom.org> <56FA27E8.2080608@siemens.com> Cc: linux-kernel@vger.kernel.org, Daniel Wagner , Jiri Kosina , Rusty Russell From: Daniel Wagner Message-ID: <56FA2B31.4040309@monom.org> Date: Tue, 29 Mar 2016 09:13:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56FA27E8.2080608@siemens.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1474 Lines: 40 On 03/29/2016 08:59 AM, Jan Kiszka wrote: > On 2016-03-29 08:41, Daniel Wagner wrote: >> for module in module_list(): >> gdb.write("{address} {name:<19} {size:>8} {ref}".format( >> - address=str(module['module_core']).split()[0], >> + module_layout=module['core_layout'] >> + addressr=str(module_layout['base']) > > This looks untested. Yep, I send out the untested version. Need more coffee... >> name=module['name'].string(), >> size=str(module['core_size']), >> ref=str(module['refcnt']['counter']))) >> diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py >> index 627750c..8650ede 100644 >> --- a/scripts/gdb/linux/symbols.py >> +++ b/scripts/gdb/linux/symbols.py >> @@ -108,7 +108,8 @@ lx-symbols command.""" >> >> def load_module_symbols(self, module): >> module_name = module['name'].string() >> - module_addr = str(module['module_core']).split()[0] >> + module_layout = module['core_layout'] >> + module_addr = str(module_layout['base']) >> >> module_file = self._get_module_file(module_name) >> if not module_file and not self.module_files_updated: >> > > Thanks, but ad4db3b24a should already be on its way into stable. Ah, I haven't got that fix yet because I am still on a older branch. Also my google-foo didn't help. Sorry about that noise. cheers, daniel