Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755979AbcC2H0X (ORCPT ); Tue, 29 Mar 2016 03:26:23 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:57657 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbcC2H0V (ORCPT ); Tue, 29 Mar 2016 03:26:21 -0400 Date: Tue, 29 Mar 2016 00:26:17 -0700 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , Al Viro , Anton Altaparmakov , xfs@oss.sgi.com, Dave Chinner , drbd-dev@lists.linbit.com, Philipp Reisner , Lars Ellenberg , Boaz Harrosh Subject: Re: [PATCH 1/8] block: move bvec iterator into include/linux/bvec_iter.h Message-ID: <20160329072617.GB18920@infradead.org> References: <1458627149-12988-1-git-send-email-ming.lei@canonical.com> <1458627149-12988-2-git-send-email-ming.lei@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458627149-12988-2-git-send-email-ming.lei@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 532 Lines: 21 > --- a/include/linux/bio.h > +++ b/include/linux/bio.h > @@ -31,6 +31,7 @@ > > /* struct bio, bio_vec and BIO_* flags are defined in blk_types.h */ > #include > +#include > > #define BIO_DEBUG > > @@ -40,10 +41,6 @@ > #define BIO_BUG_ON > #endif > > -#define BIO_MAX_PAGES 256 > -#define BIO_MAX_SIZE (BIO_MAX_PAGES << PAGE_CACHE_SHIFT) > -#define BIO_MAX_SECTORS (BIO_MAX_SIZE >> 9) I see no reason why these should be moved out of bio.h. Otherwise this looks fine to me.