Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756211AbcC2Hpl (ORCPT ); Tue, 29 Mar 2016 03:45:41 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:44470 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756026AbcC2Hpi (ORCPT ); Tue, 29 Mar 2016 03:45:38 -0400 Date: Tue, 29 Mar 2016 00:45:35 -0700 From: Christoph Hellwig To: "Ewan D. Milne" Cc: Johannes Thumshirn , "Martin K. Petersen" , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Hannes Reinecke , stable@vger.kernel.org Subject: Re: [PATCH] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state Message-ID: <20160329074535.GA30098@infradead.org> References: <1458813373-7477-1-git-send-email-jthumshirn@suse.de> <1458834164.17965.74.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458834164.17965.74.camel@localhost.localdomain> User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 443 Lines: 9 On Thu, Mar 24, 2016 at 11:42:44AM -0400, Ewan D. Milne wrote: > This looks fine. Do we still need 90a88d6ef (scsi: fix soft lockup in > scsi_remove_target() on module removal) or can that be reverted now, > since the STARGET_REMOVE state will allow the iteration to continue? Yes, that stale pointer check is something I'd really, really prefer not to have around in the long run. Otherwise the patch looks like the right direction to me.