Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756241AbcC2HqK (ORCPT ); Tue, 29 Mar 2016 03:46:10 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49606 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756222AbcC2HqI (ORCPT ); Tue, 29 Mar 2016 03:46:08 -0400 Date: Mon, 28 Mar 2016 12:35:21 -0700 From: Mark Brown To: Maarten ter Huurne Cc: Zubair Lutfullah Kakakhel , linux-kernel@vger.kernel.org Message-ID: <20160328193521.GH2350@sirena.org.uk> References: <1458223508-20740-1-git-send-email-maarten@treewalker.org> <1458223508-20740-3-git-send-email-maarten@treewalker.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nFBW6CQlri5Qm8JQ" Content-Disposition: inline In-Reply-To: <1458223508-20740-3-git-send-email-maarten@treewalker.org> X-Cookie: If anything can go wrong, it will. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 64.55.107.3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 3/4] regulator: act8865: Pass of_node via act8865_regulator_data X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1001 Lines: 29 --nFBW6CQlri5Qm8JQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 17, 2016 at 03:05:07PM +0100, Maarten ter Huurne wrote: > This makes the code easier to read and it avoids a dynamic memory > allocation. Please write better changelogs. This is a very fiddly and non obvious set of transformations and it takes far too much effort to work out what this change does and why it's safe. --nFBW6CQlri5Qm8JQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW+Yd2AAoJECTWi3JdVIfQ93UH/1rnsMspw4dMOhr6mkgYBT8D gxniypl5H5Es51ln0NaB/rXMQeT81fUq9jZ8MiNyhikMz/oEoQ31B/6fJ3cZvZyv HGi85mIO/GGeA9dskHOGGtGJqysMm34R0HCCu+1c3CvTBTS7ZLrajMhlMlWZm1Lm ArUPm0lZzBejLVmc4F6/0qjGF1ladOTRmE2/XFMbL9/5mCcaPCmIbGiQuPwBbwRB E2Ou9tI/NUgYas8c2rIgPd360bmgkhmH0G5JwC9ZHgscYzUFVEDQT4v1b6pcZEpr j8jLg93gfDJnaq2XpmNhpOsdc96xX5sy+XuPetbMHQIC57NSZgz6XE8CXuwgODw= =tTEJ -----END PGP SIGNATURE----- --nFBW6CQlri5Qm8JQ--