Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755947AbcC2Ix2 (ORCPT ); Tue, 29 Mar 2016 04:53:28 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:59470 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbcC2IxZ (ORCPT ); Tue, 29 Mar 2016 04:53:25 -0400 MIME-Version: 1.0 In-Reply-To: <20160329072617.GB18920@infradead.org> References: <1458627149-12988-1-git-send-email-ming.lei@canonical.com> <1458627149-12988-2-git-send-email-ming.lei@canonical.com> <20160329072617.GB18920@infradead.org> Date: Tue, 29 Mar 2016 16:53:22 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/8] block: move bvec iterator into include/linux/bvec_iter.h From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , Linux Kernel Mailing List , linux-block@vger.kernel.org, Al Viro , Anton Altaparmakov , xfs@oss.sgi.com, Dave Chinner , drbd-dev@lists.linbit.com, Philipp Reisner , Lars Ellenberg , Boaz Harrosh Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 934 Lines: 31 On Tue, Mar 29, 2016 at 3:26 PM, Christoph Hellwig wrote: >> --- a/include/linux/bio.h >> +++ b/include/linux/bio.h >> @@ -31,6 +31,7 @@ >> >> /* struct bio, bio_vec and BIO_* flags are defined in blk_types.h */ >> #include >> +#include >> >> #define BIO_DEBUG >> >> @@ -40,10 +41,6 @@ >> #define BIO_BUG_ON >> #endif >> >> -#define BIO_MAX_PAGES 256 >> -#define BIO_MAX_SIZE (BIO_MAX_PAGES << PAGE_CACHE_SHIFT) >> -#define BIO_MAX_SECTORS (BIO_MAX_SIZE >> 9) > > I see no reason why these should be moved out of bio.h. You are right, these should be kept in bio.h. Thanks for your review! > > Otherwise this looks fine to me. > -- > To unsubscribe from this list: send the line "unsubscribe linux-block" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html