Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756571AbcC2Jn0 (ORCPT ); Tue, 29 Mar 2016 05:43:26 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:34255 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756494AbcC2JnW (ORCPT ); Tue, 29 Mar 2016 05:43:22 -0400 MIME-Version: 1.0 In-Reply-To: <20160329063544.GA3588@yaowei-K42JY> References: <1458871286-3099-1-git-send-email-baiyaowei@cmss.chinamobile.com> <20160326004332.GM17997@ZenIV.linux.org.uk> <20160329063544.GA3588@yaowei-K42JY> Date: Tue, 29 Mar 2016 11:43:21 +0200 Message-ID: Subject: Re: [PATCH] fs/vfs: improve __mnt_is_readonly From: Richard Weinberger To: Yaowei Bai Cc: Al Viro , linux-fsdevel , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 808 Lines: 22 On Tue, Mar 29, 2016 at 8:35 AM, Yaowei Bai wrote: > On Sat, Mar 26, 2016 at 12:43:32AM +0000, Al Viro wrote: >> On Fri, Mar 25, 2016 at 10:01:26AM +0800, Yaowei Bai wrote: >> > This patch refactors __mnt_is_readonly and makes it return bool to >> > improve readability due to this particular function only using either >> > one or zero as its return value. >> >> Improve in which way, if I may ask? > > A boolean return value can be more matchable with function's name and > more suitable as this function only returns 0/1. Please also think of the arguments made on linux-mtd[1]. Hopping from one subsystem to another trying to sneak patches in is not the best idea... :-) [1]: http://lists.infradead.org/pipermail/linux-mtd/2016-March/066296.html -- Thanks, //richard