Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752462AbcC2Mb1 (ORCPT ); Tue, 29 Mar 2016 08:31:27 -0400 Received: from mga04.intel.com ([192.55.52.120]:52882 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760AbcC2MbZ convert rfc822-to-8bit (ORCPT ); Tue, 29 Mar 2016 08:31:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,410,1455004800"; d="scan'208";a="947189094" From: "Tirdea, Irina" To: Peter Meerwald-Stadler CC: Jonathan Cameron , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Hartmut Knaack , "Lars-Peter Clausen" , Markus Pargmann Subject: RE: [PATCH 1/1] iio: accel: bmc150: fix endianness when reading axes Thread-Topic: [PATCH 1/1] iio: accel: bmc150: fix endianness when reading axes Thread-Index: AQHRiRUI4tw+S1JaU0+3EXOYWAnfYp9vD5gAgAFLFxA= Date: Tue, 29 Mar 2016 12:31:05 +0000 Deferred-Delivery: Tue, 29 Mar 2016 12:31:00 +0000 Message-ID: <1F3AC3675D538145B1661F571FE1805F2F2158E4@irsmsx105.ger.corp.intel.com> References: <1459185141-18319-1-git-send-email-irina.tirdea@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODU2YTg5ZmUtNGE2ZC00ZGFhLTg4YzYtMGJiZDVlNjdmNjVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlZIU2RISE5SMzRuSE5Va2RTWmFpcnE2TTBFa2Y4SjBGMG1nVDhlRHJtbHc9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1279 Lines: 38 > -----Original Message----- > From: linux-iio-owner@vger.kernel.org [mailto:linux-iio-owner@vger.kernel.org] On Behalf Of Peter Meerwald-Stadler > Sent: 28 March, 2016 20:43 > To: Tirdea, Irina > Cc: Jonathan Cameron; linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org; Hartmut Knaack; Lars-Peter Clausen; Markus > Pargmann > Subject: Re: [PATCH 1/1] iio: accel: bmc150: fix endianness when reading axes > > On Mon, 28 Mar 2016, Irina Tirdea wrote: > > > For big endian platforms, reading the axes will return > > invalid values. > > > > The device stores each axis value in a 16 bit little > > endian register. The driver uses regmap_read_bulk to get > > the axis value, resulting in a 16 bit little endian value. > > This needs to be converted to cpu endianness to work > > on big endian platforms. > > > > Fix endianness for big endian platforms by converting > > the values for the axes read from little endian to > > cpu. > > > > This is also partially fixed in commit b6fb9b6d6552 ("iio: > > accel: bmc150: optimize transfers in trigger handler"). > > looks good > > in bmc150_accel_get_axis() the call to regmap_bulk_read() could now pass > sizeof(raw_val) instead of 2 > Yes, that would look better. I'll send a new version with this change. Thanks, Irina