Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756404AbcC2NQH (ORCPT ); Tue, 29 Mar 2016 09:16:07 -0400 Received: from www.linutronix.de ([62.245.132.108]:54656 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752489AbcC2NQF (ORCPT ); Tue, 29 Mar 2016 09:16:05 -0400 From: Richard Cochran To: Cc: Subject: [PATCH 00/10] intel_idle: Fix hot plug handling. Date: Tue, 29 Mar 2016 15:15:52 +0200 Message-Id: X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1427 Lines: 34 This driver has one serious and one mild bug in its hot plug handling. First, whenever a new CPU goes on line, if the call to cpuidle_register_driver() should fail (say, due to lack of memory), then the driver frees its per-CPU region. On the *next* CPU_ONLINE event, the driver will happily use the region again and even free it again if the failure repeats. Second, for each new on line CPU, a device is registered with the cpuidle layer. However, when a CPU goes down, its device is never unregistered, even if the module exits. Although this driver may not (yet?) be a built as a module, still this patch series cleans up the exit path in order to make the resource allocations clear. Richard Cochran (10): intel_idle: remove useless return from void function. intel_idle: Fix a helper function's return value. intel_idle: Remove redundant initialization calls. intel_idle: Fix deallocation order on the driver exit path. intel_idle: Fix dangling registration on error path. intel_idle: Avoid a double free of the per-CPU data. intel_idle: Setup the timer broadcast only on successful driver load. intel_idle: Don't overreact to a cpuidle registration failure. intel_idle: Propagate hot plug errors. intel_idle: Clean up all registered devices on exit. drivers/idle/intel_idle.c | 61 ++++++++++++++++++++++++----------------------- 1 file changed, 31 insertions(+), 30 deletions(-) -- 2.1.4