Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756272AbcC2Nk7 (ORCPT ); Tue, 29 Mar 2016 09:40:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:43292 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752055AbcC2Nk5 (ORCPT ); Tue, 29 Mar 2016 09:40:57 -0400 Date: Tue, 29 Mar 2016 15:40:54 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Benjamin Tissoires cc: Josh Boyer , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: lenovo: Don't use stack variables for DMA buffers In-Reply-To: <20160329065027.GA20424@mail.corp.redhat.com> Message-ID: References: <1459171334-22943-1-git-send-email-jwboyer@fedoraproject.org> <1459171334-22943-2-git-send-email-jwboyer@fedoraproject.org> <20160329065027.GA20424@mail.corp.redhat.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 776 Lines: 24 On Tue, 29 Mar 2016, Benjamin Tissoires wrote: > > The lenovo_send_cmd_cptkbd function uses a stack variable to submit > > commands via hid_hw_raw_request. Eventually this gets to the > > usb_hcd_map_urb_for_dma function, which causes a warning to be thrown > > if the CONFIG_DMA_API_DEBUG option is enabled. > > > > Fix this by allocating a temporary buffer instead. > > > > Reported-by: lejeczek > > Signed-off-by: Josh Boyer > > --- > > The patch is > Reviewed-by: Benjamin Tissoires > > There is just one nitpick that can be solved while committing (or not, > depending on how Jiri handles it :-P ). I've nuked the NULL-initialization and applied, thanks! -- Jiri Kosina SUSE Labs