Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756765AbcC2N7D (ORCPT ); Tue, 29 Mar 2016 09:59:03 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:64270 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753890AbcC2N67 (ORCPT ); Tue, 29 Mar 2016 09:58:59 -0400 From: Arnd Bergmann To: Ludovic Desroches Cc: nicolas.ferre@atmel.com, alexandre.belloni@free-electrons.com, plagnioj@jcrosoft.com, boris.brezillon@free-electrons.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ARM: at91: use chipid device for soc detection Date: Tue, 29 Mar 2016 15:55:55 +0200 Message-ID: <55618572.U3p4crGV1Y@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1458285681-25684-1-git-send-email-ludovic.desroches@atmel.com> References: <1458285681-25684-1-git-send-email-ludovic.desroches@atmel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:oLAmsw8wzvcoaAc/LiolgPY+QGwPou22VvCZ5V8lFkBSfZgLTfU /YwrFYudBLiMQIr8tecH/UyxbTkzmGJipIyyO7KwqwKDi1LSwPVSbDZoYd3Jl8xn/L+2Moy OmT8pa7IdaY1LnEK9MKES/AhtreDsNjP+jupTY9sli6uThRxq7CBjtCbAZP7wxDCNDvKCgD qafgBe5rk4nmArjoymYjg== X-UI-Out-Filterresults: notjunk:1;V01:K0:u0f7oYEvOD0=:qvVexgjR+UHCJifsOI92z+ 9chAAEPLKucXi3NFY40vkQcdc1x8KQJTxE9/YElE7EfB6K2oWX9B1kTJ9ih/9LzWmMN+D60eL N+Q87Nxhy+urKFfwgM/RwWBlbovg5XgaFaeTnj6kccvjZBH6hId0O9udzwrJ5yrksunDCI2K5 nydwVEvnS/yRvmJyIJAyRKilqJBW+PX5YFYBy/cvNqpqaLRgv7TJSwO5ngjVhmKEO33YFClT8 9piDJLFcHD8lwEwkeqWvmR3F6g3NGcg5r/RXB7I89zMdqeZxvNAznq/8nS4bsliPeqivKCVKv UPZPLlDJS385xcXIzSN5S/iz13mKxTx7xNz9TYAAR1DmgjvLIaG5A9N3APraYvlHC9ypzEsbl 0HmprRruJQBTLxn/c97r2gdwB/h+mxzdyiuIzw0v8jKNkjdzFfkFPsn+Zm2kASpLn7m91Zun3 CsrSdeVH+z72zB/FEjbdlPNCWK18o7uPKohXxZD8BVMDHwGOq4J7NjGXEuoCf8N46+FB/ZjW6 kggAeI1gbhqCa/P7JEMjghCErNfdlNKWE47KYbvmtnIMM11Sxt/vktcX46TuGo+pkXc5Td9Qc s8IXAwKLE5/3OaGcpRt0HxFVT+FG8NeoO408wdg9bzJBft8MHZSam2SUitOQBIHUyA/n5Q/ux wIQRaALJSx3l3SpcxLsJfDyOlR7VduSKBWJJDX42LkDpc8PhnMIlXRdM6Zal/jmaw8pLkO7My lT8MlC2hWaWX9R9F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 328 Lines: 14 On Friday 18 March 2016 08:21:19 Ludovic Desroches wrote: > -struct soc_device * __init at91_soc_init(const struct at91_soc *socs) > +int __init at91_get_cidr_exid_from_dbgu(u32 *cidr, u32 *exid) > { > + > +int __init at91_get_cidr_exid_from_chipid(u32 *cidr, u32 *exid) > +{ > These should both be 'static', right? Arnd