Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756917AbcC2OCt (ORCPT ); Tue, 29 Mar 2016 10:02:49 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:34701 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbcC2OCs (ORCPT ); Tue, 29 Mar 2016 10:02:48 -0400 Date: Tue, 29 Mar 2016 15:02:44 +0100 From: Al Viro To: Arend Van Spriel Cc: Junichi Nomura , "linux-kernel@vger.kernel.org" , Linux NFS Mailing List Subject: Re: [REGRESSION 4.6-rc1] NFS mounts (using autofs) failing Message-ID: <20160329140244.GV17997@ZenIV.linux.org.uk> References: <56FA62FB.1080506@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56FA62FB.1080506@broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1109 Lines: 37 On Tue, Mar 29, 2016 at 01:11:55PM +0200, Arend Van Spriel wrote: > Hi Al, > > Moved to 4.6-rc1 and found NFS mounts were failing moving to the new > kernel. The NFS mounts are done using autofs. Below is the bisect log > and attached the kernel .config file. Let me know if you need any other > information. AFAICS, it's the same one that got reported yesterday by Junichi Nomura. Folks, could you check if the delta below fixes it? diff --git a/fs/namei.c b/fs/namei.c index 3498d53..0d80c72 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1740,15 +1740,17 @@ static int walk_component(struct nameidata *nd, int flags) nd->flags); if (IS_ERR(path.dentry)) return PTR_ERR(path.dentry); - if (unlikely(d_is_negative(path.dentry))) { - dput(path.dentry); - return -ENOENT; - } + path.mnt = nd->path.mnt; err = follow_managed(&path, nd); if (unlikely(err < 0)) return err; + if (unlikely(d_is_negative(path.dentry))) { + path_to_nameidata(&path, nd); + return -ENOENT; + } + seq = 0; /* we are already out of RCU mode */ inode = d_backing_inode(path.dentry); }