Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756890AbcC2OEi (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Mar 2016 10:04:38 -0400
Received: from eusmtp01.atmel.com ([212.144.249.242]:48970 "EHLO
	eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751998AbcC2OEg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Mar 2016 10:04:36 -0400
Subject: Re: [PATCH 1/3] ARM: at91: use chipid device for soc detection
To: Arnd Bergmann <arnd@arndb.de>,
        Ludovic Desroches <ludovic.desroches@atmel.com>
References: <1458285681-25684-1-git-send-email-ludovic.desroches@atmel.com>
 <55618572.U3p4crGV1Y@wuerfel>
CC: <alexandre.belloni@free-electrons.com>, <plagnioj@jcrosoft.com>,
        <boris.brezillon@free-electrons.com>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
From: Nicolas Ferre <nicolas.ferre@atmel.com>
Organization: atmel
Message-ID: <56FA8B6F.4010008@atmel.com>
Date: Tue, 29 Mar 2016 16:04:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <55618572.U3p4crGV1Y@wuerfel>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.161.30.18]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 463
Lines: 19

Le 29/03/2016 15:55, Arnd Bergmann a ?crit :
> On Friday 18 March 2016 08:21:19 Ludovic Desroches wrote:
>> -struct soc_device * __init at91_soc_init(const struct at91_soc *socs)
>> +int __init at91_get_cidr_exid_from_dbgu(u32 *cidr, u32 *exid)
>>  {
> 
> 
>> +
>> +int __init at91_get_cidr_exid_from_chipid(u32 *cidr, u32 *exid)
>> +{
>>
> 
> These should both be 'static', right?

Absolutely. I modify this right now and repost a patch.

Bye,
-- 
Nicolas Ferre