Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757392AbcC2PzC (ORCPT ); Tue, 29 Mar 2016 11:55:02 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:36114 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751927AbcC2PzA (ORCPT ); Tue, 29 Mar 2016 11:55:00 -0400 Date: Tue, 29 Mar 2016 15:54:52 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Arnd Bergmann CC: "Zhangjian (Bamvor)" , Yury Norov , , Andreas Schwab , , , , , , "jijun (D)" , , , , , , , , , Bamvor Zhang Jian , Subject: Re: [RFC5 PATCH v6 00/21] ILP32 for ARM64 In-Reply-To: <3298847.t7vI4YM3gJ@wuerfel> Message-ID: References: <1452792198-10718-1-git-send-email-ynorov@caviumnetworks.com> <20160329120147.GA3551@yury-N73SV> <56FA816D.60101@huawei.com> <3298847.t7vI4YM3gJ@wuerfel> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 900 Lines: 21 On Tue, 29 Mar 2016, Arnd Bergmann wrote: > In glibc, I think we need to define fewer entry points, not more. > Instead of having both lseek and lseek64, only one of them should > be provided, and that should always take a 64-bit offset, calling > into the kernel with the _llseek syscall entry. lseek64 is part of the public API, on all platforms. It should be aliased to lseek where possible. Strictly, it would be possible to provide it in the API without it being part of the ABI, by arranging the headers so that calls to lseek64 result in objects with a reference to lseek (because it uses the off64_t typedef, it's not valid to declare it yourself rather than including a header that declares it). I don't think it would be a good idea for a new sub-architecture port to try introducing such a difference from all other ports, however. -- Joseph S. Myers joseph@codesourcery.com