Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752937AbcC2QM0 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Mar 2016 12:12:26 -0400
Received: from smtprelay0175.hostedemail.com ([216.40.44.175]:47076 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751729AbcC2QMY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Mar 2016 12:12:24 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:968:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3653:3865:3867:3868:3870:3871:3872:3874:4250:4321:5007:6120:7903:7974:8957:10004:10400:10848:11232:11658:11783:11914:12043:12048:12296:12517:12519:12740:13069:13161:13229:13311:13357:13439:13894:14181:14659:14721:21080:21212:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: range82_87632a226364e
X-Filterd-Recvd-Size: 2186
Message-ID: <1459267929.25110.80.camel@perches.com>
Subject: Re: [RFC PATCH] acpi: Use a more normal logging style for
 ACPI_<LEVEL> calls
From: Joe Perches <joe@perches.com>
To: "Moore, Robert" <robert.moore@intel.com>, "Zheng, Lv" <lv.zheng@intel.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
        Len Brown <lenb@kernel.org>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "devel@acpica.org" <devel@acpica.org>
Date: Tue, 29 Mar 2016 09:12:09 -0700
In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37E4553F8@ORSMSX110.amr.corp.intel.com>
References: <1459222225.25110.58.camel@perches.com>
	 <94F2FBAB4432B54E8AACC7DFDE6C92E37E4553D5@ORSMSX110.amr.corp.intel.com>
	 <94F2FBAB4432B54E8AACC7DFDE6C92E37E4553F8@ORSMSX110.amr.corp.intel.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.2-0ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 967
Lines: 31

On Tue, 2016-03-29 at 15:34 +0000, Moore, Robert wrote:
> On the other hand, we removed AE_INFO from ACPI_INFO a while back, and
> this may remove the necessity for the double parens.

Does remove the necessity.

I suppose I could look through the ACPICA sources and generate
the same patch in the ACPICA style.

I didn't manage to run the script that does the style
conversion though.

$ git clone git://github.com/acpica/acpica.git
$ cd acpica
$ make
$

now what?

Removing AE_INFO from ACPI_(WARNING|ERROR) (it seems there
are only a few uses without it and those uses seem
equivalent) is doable too.

For instance:

$ git grep -w ACPI_ERROR|grep -v AE_INFO
[]
source/components/utilities/utobject.c:????????ACPI_ERROR ((ModuleName, LineNumber,
source/components/utilities/uttrack.c:????????ACPI_ERROR ((Module, Line,
source/components/utilities/uttrack.c:????????ACPI_ERROR ((Module, Line,
source/components/utilities/uttrack.c:????????ACPI_ERROR ((Module, Line,