Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757594AbcC2QgE (ORCPT ); Tue, 29 Mar 2016 12:36:04 -0400 Received: from foss.arm.com ([217.140.101.70]:41592 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752811AbcC2QgB (ORCPT ); Tue, 29 Mar 2016 12:36:01 -0400 Subject: Re: [PATCH v7 10/17] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI To: Shannon Zhao , linux-arm-kernel@lists.infradead.org, stefano.stabellini@citrix.com, david.vrabel@citrix.com References: <1458830676-27075-1-git-send-email-shannon.zhao@linaro.org> <1458830676-27075-11-git-send-email-shannon.zhao@linaro.org> Cc: devicetree@vger.kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, peter.huangpeng@huawei.com, xen-devel@lists.xen.org, zhaoshenglong@huawei.com From: Julien Grall Message-ID: <56FAAEED.7060108@arm.com> Date: Tue, 29 Mar 2016 17:35:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1458830676-27075-11-git-send-email-shannon.zhao@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1775 Lines: 62 Hi Shannon, On 24/03/16 14:44, Shannon Zhao wrote: > When booting with ACPI, it could get the event-channel irq through The kernel will always get the event-channel IRQ through HVM_PARAM_CALLBACK_IRQ. So I would say: ", the kernel will get the event-channel..." > HVM_PARAM_CALLBACK_IRQ. > > Signed-off-by: Shannon Zhao > Reviewed-by: Stefano Stabellini > --- > arch/arm/xen/enlighten.c | 36 +++++++++++++++++++++++++++++++++++- > 1 file changed, 35 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c > index d94f726..680aae0 100644 > --- a/arch/arm/xen/enlighten.c > +++ b/arch/arm/xen/enlighten.c > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include > > #include > > @@ -278,6 +279,35 @@ void __init xen_early_init(void) > add_preferred_console("hvc", 0, NULL); > } > > +static void __init xen_acpi_guest_init(void) > +{ > +#ifdef CONFIG_ACPI > + struct xen_hvm_param a; > + int interrupt, trigger, polarity; > + > + a.domid = DOMID_SELF; > + a.index = HVM_PARAM_CALLBACK_IRQ; > + xen_events_irq = 0; > + > + if (!HYPERVISOR_hvm_op(HVMOP_get_param, &a)) { > + if ((a.value >> 56) == HVM_PARAM_CALLBACK_TYPE_PPI) { > + interrupt = a.value & 0xff; > + trigger = ((a.value >> 8) & 0x1) ? ACPI_EDGE_SENSITIVE > + : ACPI_LEVEL_SENSITIVE; > + polarity = ((a.value >> 8) & 0x2) ? ACPI_ACTIVE_LOW > + : ACPI_ACTIVE_HIGH; > + xen_events_irq = acpi_register_gsi(NULL, interrupt, > + trigger, polarity); > + } > + } Can you invert the condition to remove one layer of indentation? Regards, -- Julien Grall