Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757867AbcC2ROj (ORCPT ); Tue, 29 Mar 2016 13:14:39 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:52102 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757849AbcC2ROh (ORCPT ); Tue, 29 Mar 2016 13:14:37 -0400 Date: Tue, 29 Mar 2016 10:14:12 -0700 From: Mark Brown To: Baolin Wang Cc: Peter Chen , Peter Chen , Felipe Balbi , Greg KH , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Peter Chen , Alan Stern , "r.baldyga@samsung.com" , Yoshihiro Shimoda , Lee Jones , Charles Keepax , "patches@opensource.wolfsonmicro.com" , Linux PM list , USB , "device-mainlining@lists.linuxfoundation.org" , LKML Message-ID: <20160329171412.GY2350@sirena.org.uk> References: <20160325070937.GA22398@peterchendt> <20160328071351.GC3302@peterchendt> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iIOavGAISvUeFFLW" Content-Disposition: inline In-Reply-To: X-Cookie: If anything can go wrong, it will. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 64.55.107.4 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1428 Lines: 36 --iIOavGAISvUeFFLW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 29, 2016 at 10:05:23AM +0800, Baolin Wang wrote: > Yes, The user 'wm831x_power' did not implement any callbacks in > 'usb_charger_detect_type()' function, but in > 'usb_charger_detect_type()' function it just supplies different > callbacks to get the charger type with simple logic. Anyway we can try > to implement one callback to get the charger type and test the API. The wm831x doesn't have any charger detection features, what it does have is hardware for implementing a current limit on the power drawn =66rom USB. What it's looking for from this framework is for something to tell it how much current it should draw from USB so it can program the hardware appropriately to impose that limit. --iIOavGAISvUeFFLW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW+rfiAAoJECTWi3JdVIfQZd4H/3omY61Hj4mr8vYVCj9ZDZ7x 7u6/fsLzXJgq3CbJXi8HvLlj20rYncH9i++yNeVSVegYsuRvBY91stUcSenJwz2b Baz3dLRJ0E3nDxej8isxBdNObh863a7hPaWhDJE58jTy9ASCvzFuvonH86C8tW/a bSDMAkbHzvHcvRP/wftKc6MIemKCXFIz0eKEWFS5Rv30Y9XpfejJqg8IF2GE70D2 H8/heSuhHR70m0n+nAtnGtcyq9xB5QxLucrPn55HJDHnX/pEmGxleyD4W1URDkgK qWEKka43HtNPv67QMljp/BT94xbQCbdak8tAQZoewnFBYDfkg51GYGWtD7U1W3M= =FRjf -----END PGP SIGNATURE----- --iIOavGAISvUeFFLW--