Message-ID: <1459273826.2630.10.camel@free.fr>
Subject: Re: [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call
 to a long function
From: Dominique van den Broeck <domdevlin@free.fr>
Reply-To: domdevlin@free.fr
To: Joe Perches <joe@perches.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Peter Hurley <peter@hurleysoftware.com>,
        Shraddha Barke <shraddha.6596@gmail.com>,
        Radek Dostal <rd@radekdostal.com>
Cc: linux-kernel@vger.kernel.org
Date: Tue, 29 Mar 2016 19:50:26 +0200
In-Reply-To: <1459273107.25110.91.camel@perches.com>
References: <1459271662-14990-1-git-send-email-domdevlin@free.fr>
	 <1459271662-14990-3-git-send-email-domdevlin@free.fr>
	 <1459273107.25110.91.camel@perches.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 934
Lines: 27

> Does this really look better to you?
>
> Long identifiers like "wait_event_interruptible_timeout"
> (32 chars) make
> using 80 columns a bit silly.
> 
> Please remember checkpatch is a stupid script and that
> not every warning it emits is dicta.

Actually, not much and as a matter of fact, I hesitated before sending
this particular patch. That's also why I submitted it as the last one
of them all and why it fixes only a single row : so we can eventually
reject it easily.

I'm not a checkpatch.pl nazi neither and anyway, even the "Development
Process" document specify that it's not to be considered as a strict
rule if it makes the things worse.

But I found it useful anyway because this set brings back all the
warnings to only two categories (comments over spinlocks and memory
barriers) and also because this kind of minor corrections could still
be appreciated by people that have better things to do... :-)

Cheers.