Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757531AbcC2SYA (ORCPT ); Tue, 29 Mar 2016 14:24:00 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:34109 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbcC2SX7 (ORCPT ); Tue, 29 Mar 2016 14:23:59 -0400 MIME-Version: 1.0 In-Reply-To: <1459275259-28040-1-git-send-email-dvlasenk@redhat.com> References: <1459275259-28040-1-git-send-email-dvlasenk@redhat.com> Date: Tue, 29 Mar 2016 14:23:57 -0400 X-Google-Sender-Auth: Xqi0chzpr2C6akRqO8JHVzNcAa4 Message-ID: Subject: Re: [PATCH] compiler.h: Provide __always_inline to userspace headers too From: Josh Boyer To: Denys Vlasenko Cc: Linus Torvalds , Thomas Graf , Peter Zijlstra , David Rientjes , Arnd Bergmann , Ingo Molnar , Andrew Morton , "Linux-Kernel@Vger. Kernel. Org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1412 Lines: 41 On Tue, Mar 29, 2016 at 2:14 PM, Denys Vlasenko wrote: > Recent change to uapi/linux/swab.h needs this. > > Signed-off-by: Denys Vlasenko > CC: Josh Boyer > CC: Thomas Graf > CC: Peter Zijlstra > CC: David Rientjes > CC: Arnd Bergmann > CC: Ingo Molnar > CC: Andrew Morton > CC: Linus Torvalds > CC: linux-kernel@vger.kernel.org > --- > include/linux/compiler.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/compiler.h b/include/linux/compiler.h > index b5ff988..2cb6ba4 100644 > --- a/include/linux/compiler.h > +++ b/include/linux/compiler.h > @@ -397,12 +397,12 @@ static __always_inline void __write_once_size(volatile void *p, void *res, int s > */ > #define noinline_for_stack noinline > > +#endif /* __KERNEL__ */ > + > #ifndef __always_inline > #define __always_inline inline > #endif > > -#endif /* __KERNEL__ */ > - Did you test this by installing the headers with 'make headers-install' and trying to build something with the newly installed headers? As I said in my other email, I don't see how changes to this particular file are reflected in anything that gets installed in /usr/include by the uapi mechanism. josh