Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757501AbcC2Sn3 (ORCPT ); Tue, 29 Mar 2016 14:43:29 -0400 Received: from mail-by2on0131.outbound.protection.outlook.com ([207.46.100.131]:43376 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751877AbcC2Sn1 convert rfc822-to-8bit (ORCPT ); Tue, 29 Mar 2016 14:43:27 -0400 From: Yuval Mintz To: Colin King , netdev CC: linux-kernel , Dept-Eng Everest Linux L2 , Ariel Elior Subject: RE: [PATCH] qed: initialize return rc to avoid returning garbage Thread-Topic: [PATCH] qed: initialize return rc to avoid returning garbage Thread-Index: AQHRidyRZi9ZU3vOq0ST+9La38e29J9wvQfg Date: Tue, 29 Mar 2016 18:28:04 +0000 Message-ID: References: <1459270850-16177-1-git-send-email-colin.king@canonical.com> In-Reply-To: <1459270850-16177-1-git-send-email-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: canonical.com; dkim=none (message not signed) header.d=none;canonical.com; dmarc=none action=none header.from=qlogic.com; x-originating-ip: [2.54.171.137] x-ms-office365-filtering-correlation-id: cc8694bf-018b-42a7-ac99-08d357ffde1c x-microsoft-exchange-diagnostics: 1;BLUPR11MB0818;5:MpH5t416CX9mnGfCfDiNdQHKrUDFajTQQGRrYnaxzIROgUjTPSSrZZjrsffzo7UvOkb4GmxpMy3IO+XJA2cotsYVugtZvgu+m19dFkoq3v1Z4C52fiveE63MlSppzJWLr1A+AlSuxf9BXu4GyidTcw==;24:gdJ+RwJbPrjTtENDbWGSFpESEahNfVrrhBAf9ZsjQ8xqm8HYcs3hE2GmErvk4Pfdj7LwHCQVhxgpQrTFjMDgnAgYh/e89ditf/PR1MUfKCQ=;20:6uuhyupvjcaynP5u4Zgu/ea5Og2+h8hozkfv9OIJGDgCoy3fIdPCwIL6DojcrKX+OE4UMp1mcAXHNPrIG4vIEUpM+xmTUD9cwLr/F/4kZy4wDWtez4fxr7ymmaw0Kt5uOA+egfP40pPEN4brJNiY6Eu8kmSnmGFIfh3rzs1SMnQ= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR11MB0818; x-ld-processed: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:BLUPR11MB0818;BCL:0;PCL:0;RULEID:;SRVR:BLUPR11MB0818; x-forefront-prvs: 0896BFCE6C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(5004730100002)(77096005)(2900100001)(10400500002)(2950100001)(92566002)(558084003)(106116001)(76176999)(189998001)(87936001)(66066001)(5001770100001)(50986999)(76576001)(99286002)(54356999)(86362001)(19580405001)(3660700001)(5002640100001)(4326007)(2906002)(5008740100001)(11100500001)(74316001)(3280700002)(6116002)(1220700001)(1096002)(102836003)(5003600100002)(122556002)(33656002)(81166005)(586003)(3846002)(19580395003);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR11MB0818;H:CO2PR11MB0088.namprd11.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: qlogic.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2016 18:28:04.1726 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR11MB0818 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 345 Lines: 10 > From: Colin Ian King > > in the case where qed_slowpath_irq_req is not called, rc is not assigned and so > qed_int_igu_enable will return a garbage value. > Fix this by initializing rc to 0. > > Signed-off-by: Colin Ian King Thanks Colin. Acked-by: Yuval Mintz