Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758204AbcC2U3N (ORCPT ); Tue, 29 Mar 2016 16:29:13 -0400 Received: from smtprelay0071.hostedemail.com ([216.40.44.71]:52416 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757960AbcC2U3M (ORCPT ); Tue, 29 Mar 2016 16:29:12 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3874:5007:6119:6261:7875:8603:10004:10400:10848:10967:11232:11658:11914:12517:12519:12663:12740:13069:13161:13229:13311:13357:13439:14096:14097:14181:14659:14721:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: skate74_32c5f200c9544 X-Filterd-Recvd-Size: 2214 Date: Tue, 29 Mar 2016 16:29:07 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: Daniel Bristot de Oliveira , Ingo Molnar , Thomas Gleixner , Juri Lelli , Arnaldo Carvalho de Melo , LKML , linux-rt-users Subject: Re: [PATCH V2 3/3] sched/deadline: Tracepoints for deadline scheduler Message-ID: <20160329162907.418cb972@gandalf.local.home> In-Reply-To: <20160329201145.GC3430@twins.programming.kicks-ass.net> References: <14f6caa05f73ceba69eff035ac542cad671552b3.1459182044.git.bristot@redhat.com> <20160329151649.GA12845@twins.programming.kicks-ass.net> <20160329115700.40acb336@gandalf.local.home> <20160329160401.GB3430@twins.programming.kicks-ass.net> <20160329131056.5b01780b@gandalf.local.home> <20160329201145.GC3430@twins.programming.kicks-ass.net> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 773 Lines: 20 On Tue, 29 Mar 2016 22:11:45 +0200 Peter Zijlstra wrote: > > Yes, we don't want to get rid of the old one. But it shouldn't break > > anything if we extend it. I'm thinking of extending it with a dynamic > > array to store the deadline task values (runtime, period). And for non > > deadline tasks, the array would be empty (size zero). I think that > > could be doable and maintain backward compatibility. > > Why the complexity? Why not just tack those 32 bytes on and get on with > life? 32 bytes that are zero and meaningless for 99.999% of scheduling? The scheduling tracepoint is probably the most common tracepoint used, and one of the frequent ones. 32bytes of wasted space per event can cause a lot of tracing to be missed. -- Steve