Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932503AbcC2UqZ (ORCPT ); Tue, 29 Mar 2016 16:46:25 -0400 Received: from mailhub.eng.utah.edu ([155.98.110.27]:51789 "EHLO mailhub.eng.utah.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932465AbcC2UqU (ORCPT ); Tue, 29 Mar 2016 16:46:20 -0400 Subject: Re: [PATCH v4 3/4] Sysctl: SROP Mitigation: Add Sysctl argument to disable SROP. To: Andi Kleen References: <1459281207-24377-1-git-send-email-sbauer@eng.utah.edu> <1459281207-24377-4-git-send-email-sbauer@eng.utah.edu> <20160329195906.GA9083@tassilo.jf.intel.com> Cc: linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, x86@kernel.org, luto@amacapital.net, mingo@redhat.com, tglx@linutronix.de, wmealing@redhat.com, torvalds@linux-foundation.org, Abhiram Balasubramanian , Scott Bauer From: Scotty Bauer Message-ID: <56FAE98B.8040008@eng.utah.edu> Date: Tue, 29 Mar 2016 14:46:03 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160329195906.GA9083@tassilo.jf.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-UCE-Score: -1.9 (-) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 476 Lines: 14 On 03/29/2016 01:59 PM, Andi Kleen wrote: > On Tue, Mar 29, 2016 at 01:53:26PM -0600, Scott Bauer wrote: >> This patch adds a sysctl argument to disable SROP protection. > > Sysctl needs to be documented in Documentation/sysctl/ > > Also negated sysctl is weird, normally they are positive (enable-xxx) > Sure, I can change it. This may be a dumb question: I want SROP to be enabled by default, and thus the new enable-xxx will be initialized to 1, that's fine, right?