Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758112AbcC2UxZ (ORCPT ); Tue, 29 Mar 2016 16:53:25 -0400 Received: from mga04.intel.com ([192.55.52.120]:30267 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754110AbcC2UxY (ORCPT ); Tue, 29 Mar 2016 16:53:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,412,1455004800"; d="scan'208";a="943986294" Date: Tue, 29 Mar 2016 13:53:22 -0700 From: Andi Kleen To: Scotty Bauer Cc: linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, x86@kernel.org, luto@amacapital.net, mingo@redhat.com, tglx@linutronix.de, wmealing@redhat.com, torvalds@linux-foundation.org, Abhiram Balasubramanian , Scott Bauer Subject: Re: [PATCH v4 3/4] Sysctl: SROP Mitigation: Add Sysctl argument to disable SROP. Message-ID: <20160329205322.GB9083@tassilo.jf.intel.com> References: <1459281207-24377-1-git-send-email-sbauer@eng.utah.edu> <1459281207-24377-4-git-send-email-sbauer@eng.utah.edu> <20160329195906.GA9083@tassilo.jf.intel.com> <56FAE98B.8040008@eng.utah.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56FAE98B.8040008@eng.utah.edu> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 643 Lines: 22 On Tue, Mar 29, 2016 at 02:46:03PM -0600, Scotty Bauer wrote: > > > > On 03/29/2016 01:59 PM, Andi Kleen wrote: > > On Tue, Mar 29, 2016 at 01:53:26PM -0600, Scott Bauer wrote: > >> This patch adds a sysctl argument to disable SROP protection. > > > > Sysctl needs to be documented in Documentation/sysctl/ > > > > Also negated sysctl is weird, normally they are positive (enable-xxx) > > > > Sure, I can change it. This may be a dumb question: I want SROP to be enabled by default, and thus the new > enable-xxx will be initialized to 1, that's fine, right? Yes that's fine. -Andi -- ak@linux.intel.com -- Speaking for myself only