Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758071AbcC2V14 (ORCPT ); Tue, 29 Mar 2016 17:27:56 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:61217 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754625AbcC2V1z (ORCPT ); Tue, 29 Mar 2016 17:27:55 -0400 Subject: Re: [PATCH 1/3] blk-mq: add an API to estimate hardware queue node To: Christoph Hellwig References: <68fed570910230ce847f8f3b685eeea399640a7f.1458941500.git.shli@fb.com> <20160329072443.GA18920@infradead.org> <20160329164722.GA1208161@devbig084.prn1.facebook.com> <56FAB243.5020804@fb.com> <20160329174437.GA451@infradead.org> <56FAEAD9.40908@fb.com> <20160329212009.GB18532@infradead.org> CC: Shaohua Li , , , From: Jens Axboe Message-ID: <56FAF228.7060400@fb.com> Date: Tue, 29 Mar 2016 15:22:48 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160329212009.GB18532@infradead.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-03-29_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 544 Lines: 14 On 03/29/2016 03:20 PM, Christoph Hellwig wrote: > On Tue, Mar 29, 2016 at 02:51:37PM -0600, Jens Axboe wrote: >> For Shaohua's patches, not binding per-device data to the home node makes a >> lot of sense, though. > > It does. But exposing the node estimation function just to work around > the fact that the way the cpu/node mapping is done is upside down > currently doesn't seem helpful. Let's try to revamp that first and the > rebase the rest of the series on top of that. That's fine with me, it's not exactly urgent. -- Jens Axboe